erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

exynos: gpio: add a bigger delay when reading board strappings

Browse source 
Z-state pins were not reading reliably with a 5us delay, so increase
it to 15us.

This is ported from https://gerrit.chromium.org/gerrit/64338

Signed-off-by: David Hendricks <dhendrix@chromium.org>
BUG=none
BRANCH=none
TEST=built and booted on pit

Change-Id: Ife6ea2ef5989e1a4c17913278ab972f0fd7f7f35
Reviewed-on: https://gerrit.chromium.org/gerrit/65727
Reviewed-by: Ronald G. Minnich <rminnich@chromium.org>
Tested-by: Ronald G. Minnich <rminnich@chromium.org>
Commit-Queue: David Hendricks <dhendrix@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>
This commit is contained in:
David Hendricks 2013-08-09 15:31:16 -07:00 • committed by ChromeBot
commit 76f0f8203f
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/cpu/samsung/exynos5420/gpio.c
View file

@ -206,10 +206,10 @@ int gpio_set_value(unsigned gpio, int value)
/*
* Add a delay here to give the lines time to settle
* TODO(sjg): 1us does not always work, 2 is stable, so use 5 to be safe
* TODO(dianders): 5us does not always work, 10 is stable, so use 15 to be safe
* Come back to this and sort out what the datasheet says
*/
#define GPIO_DELAY_US 5
#define GPIO_DELAY_US 15
#ifndef __BOOT_BLOCK__
/*