erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/lenovo/sklkbl_thinkpad: Replace CFR enums with booleans

Browse source 
Boolean options are intended to represent generic "Enable"/"Disable"
options, but without enum options' extra bloat in the CFR structures.

In this case, the callback function already treated the option as if
it were a boolean option, which likely only worked by chance.

Change-Id: I747ecd0b5a33d2773eda409e6578362d694154ee
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/91344
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Angel Pons 2026-02-18 21:17:23 +01:00
commit 71b7167396
1 changed files with 1 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/mainboard/lenovo/sklkbl_thinkpad/cfr.c
View file

@ -24,11 +24,7 @@ static const struct sm_object dgpu = SM_DECLARE_ENUM({
.opt_name = "dgpu_enable",
.ui_name = "dGPU",
.ui_helptext = "Enable or disable the dGPU",
.default_value = 0,
.values = (const struct sm_enum_value[]) {
{ "Disabled", 0 },
{ "Enabled", 1 },
SM_ENUM_VALUE_END },
.default_value = false,
}, WITH_CALLBACK(update_dgpu));
static struct sm_obj_form system = {