From 71b716739626fddc99b426c18df8888b67aa288a Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Wed, 18 Feb 2026 21:17:23 +0100 Subject: [PATCH] mb/lenovo/sklkbl_thinkpad: Replace CFR enums with booleans Boolean options are intended to represent generic "Enable"/"Disable" options, but without enum options' extra bloat in the CFR structures. In this case, the callback function already treated the option as if it were a boolean option, which likely only worked by chance. Change-Id: I747ecd0b5a33d2773eda409e6578362d694154ee Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/91344 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/lenovo/sklkbl_thinkpad/cfr.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mainboard/lenovo/sklkbl_thinkpad/cfr.c b/src/mainboard/lenovo/sklkbl_thinkpad/cfr.c index b5d979806d..213c90a17d 100644 --- a/src/mainboard/lenovo/sklkbl_thinkpad/cfr.c +++ b/src/mainboard/lenovo/sklkbl_thinkpad/cfr.c @@ -24,11 +24,7 @@ static const struct sm_object dgpu = SM_DECLARE_ENUM({ .opt_name = "dgpu_enable", .ui_name = "dGPU", .ui_helptext = "Enable or disable the dGPU", - .default_value = 0, - .values = (const struct sm_enum_value[]) { - { "Disabled", 0 }, - { "Enabled", 1 }, - SM_ENUM_VALUE_END }, + .default_value = false, }, WITH_CALLBACK(update_dgpu)); static struct sm_obj_form system = {