erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/starlabs/starlite_adl: Select more appropriate macros for USB ports

Browse source 
Add the trace lengths as comments, and update the macros used for the
USB ports accordingly.

Like other boards, avoid the `USB2_PORT_TYPE_C` macro, as it makes
ports behave inconsistantly.

Change-Id: Id193b3ed86c58aedc7d5a1f384f2829a2bf18671
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85974
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Sean Rhodes 2025-01-14 09:03:24 +00:00
commit 70aa7c1e11
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb
View file

@ -49,22 +49,22 @@ chip soc/intel/alderlake
end
device ref gna on end
device ref xhci on
# Bottom USB 3.0 Type-C
register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)"
# Bottom USB 3.0 Type-C 3289 mil
register "usb2_ports[0]" = "USB2_PORT_SHORT(OC_SKIP)"
register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)"
# Top USB 3.0 Type-C
register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)"
# Top USB 3.0 Type-C 4237 mil
register "usb2_ports[1]" = "USB2_PORT_SHORT(OC_SKIP)"
register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)"
# Detachable Keyboard + SD Card Reader
register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)"
# Detachable Keyboard + SD Card Reader 6418 mil
register "usb2_ports[2]" = "USB2_PORT_SHORT(OC_SKIP)"
# Camera + Webcam
register "usb2_ports[CONFIG_CCD_PORT]" = "USB2_PORT_MID(OC_SKIP)"
# Camera + Webcam 3249 mil
register "usb2_ports[CONFIG_CCD_PORT]" = "USB2_PORT_SHORT(OC_SKIP)"
# Internal Bluetooth
register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)"
# Internal Bluetooth 1874 mil
register "usb2_ports[9]" = "USB2_PORT_SHORT(OC_SKIP)"
chip drivers/usb/acpi
device ref xhci_root_hub on