From 70aa7c1e1120354f5ddefe0db87ba0a8aafa26b6 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 14 Jan 2025 09:03:24 +0000 Subject: [PATCH] mb/starlabs/starlite_adl: Select more appropriate macros for USB ports Add the trace lengths as comments, and update the macros used for the USB ports accordingly. Like other boards, avoid the `USB2_PORT_TYPE_C` macro, as it makes ports behave inconsistantly. Change-Id: Id193b3ed86c58aedc7d5a1f384f2829a2bf18671 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/85974 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- .../starlite_adl/variants/mk_v/devicetree.cb | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index 8c87eff23b..cca605909f 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -49,22 +49,22 @@ chip soc/intel/alderlake end device ref gna on end device ref xhci on - # Bottom USB 3.0 Type-C - register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" + # Bottom USB 3.0 Type-C 3289 mil + register "usb2_ports[0]" = "USB2_PORT_SHORT(OC_SKIP)" register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" - # Top USB 3.0 Type-C - register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)" + # Top USB 3.0 Type-C 4237 mil + register "usb2_ports[1]" = "USB2_PORT_SHORT(OC_SKIP)" register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" - # Detachable Keyboard + SD Card Reader - register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" + # Detachable Keyboard + SD Card Reader 6418 mil + register "usb2_ports[2]" = "USB2_PORT_SHORT(OC_SKIP)" - # Camera + Webcam - register "usb2_ports[CONFIG_CCD_PORT]" = "USB2_PORT_MID(OC_SKIP)" + # Camera + Webcam 3249 mil + register "usb2_ports[CONFIG_CCD_PORT]" = "USB2_PORT_SHORT(OC_SKIP)" - # Internal Bluetooth - register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" + # Internal Bluetooth 1874 mil + register "usb2_ports[9]" = "USB2_PORT_SHORT(OC_SKIP)" chip drivers/usb/acpi device ref xhci_root_hub on