erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/fatcat: Configure host command ranges for FATCAT4ES variant

Browse source 
The commit introduces changes to support the FATCAT4ES board variant
by updating the EC command range configuration. The changes updates the
gen1_dec register to configure correctly to accomdate the FATCAT4ES
variant which ensures the ec-host communication should not fail. Also it
ensures other conditional checks in the EC header file for enabling this
new variant.

BUG=b:432676108
TEST=Build with the FATCAT4ES configuration and verify ec host
    communication is not failing.

Change-Id: I5c84dc2161847f9fe4316c0e63aa876696947423
Signed-off-by: Megha Verma <megha.verma@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/88552
Reviewed-by: <srinivas.kulkarni@intel.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Megha Verma 2025-07-24 12:12:49 +05:30 • committed by Subrata Banik
commit 69e6d96aad
3 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb
View file

@ -8,7 +8,7 @@ chip soc/intel/pantherlake
# EC host command ranges are in 0x800-0x807 & 0x200-0x20f
# For Fatcat variants with ITE/Nuvoton EC:
# EC host command ranges are in 0x800-0x8ff & 0x200-0x20f
register "gen1_dec" = "CONFIG(BOARD_GOOGLE_FATCAT) || CONFIG(BOARD_GOOGLE_FATCATISH) ? 0x00040801 : 0x00fc0801"
register "gen1_dec" = "CONFIG(BOARD_GOOGLE_FATCAT) || CONFIG(BOARD_GOOGLE_FATCAT4ES) || CONFIG(BOARD_GOOGLE_FATCATISH) ? 0x00040801 : 0x00fc0801"
register "gen2_dec" = "0x000c0201"
# EC memory map range is 0x900-0x9ff
register "gen3_dec" = "0x00fc0901"

4
src/mainboard/google/fatcat/variants/baseboard/fatcat/include/baseboard/ec.h
View file

@ -75,7 +75,9 @@
/* Enable EC backed PD MCU device in ACPI */
#define EC_ENABLE_PD_MCU_DEVICE
#if !CONFIG(BOARD_GOOGLE_FATCAT) && !CONFIG(BOARD_GOOGLE_FATCATISH)
#if !CONFIG(BOARD_GOOGLE_FATCAT) \
&& !CONFIG(BOARD_GOOGLE_FATCAT4ES) \
&& !CONFIG(BOARD_GOOGLE_FATCATISH)
#define EC_ENABLE_SYNC_IRQ /* Enable tight timestamp / wake support */
#define EC_SYNC_IRQ_WAKE_CAPABLE /* Let the OS know ec_sync is wake capable */
#endif

2
src/mainboard/google/fatcat/variants/fatcat/gpio.c
View file

@ -196,7 +196,7 @@ static const struct pad_config gpio_table[] = {
PAD_CFG_GPO(GPP_E03, 1, PLTRST),
/* GPP_E06: SECURE_CAM_SW */
PAD_CFG_GPI_TRIG_OWN(GPP_E06, NONE, PLTRST, LEVEL, ACPI),
#if CONFIG(BOARD_GOOGLE_FATCAT) || CONFIG(BOARD_GOOGLE_FATCATISH)
#if CONFIG(BOARD_GOOGLE_FATCAT) || CONFIG(BOARD_GOOGLE_FATCAT4ES) || CONFIG(BOARD_GOOGLE_FATCATISH)
/* GPP_E07: Not used */
PAD_NC(GPP_E07, NONE),
#else