erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/starlabs/starbook/kbl: Update HDA verb table

Browse source 
Remove presence detection flag for the DMIC and internal speakers.
While we're at it, fix the (non-functional) descriptive flags for
those two verbs as well. Remove unnecessary line continuations.

TEST=build/boot Win11 and Linux on Starbook KBL, verify speaker and
intermal mic working, as well as headphones/jack mic when plugged in.

Change-Id: I4d4a41736faac944b3165a56fe5846f24c20f549
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/89044
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
This commit is contained in:
Matt DeVillier 2025-09-04 11:01:32 -05:00 • committed by Sean Rhodes
commit 5e2f5050ba
1 changed files with 36 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

72
src/mainboard/starlabs/starbook/variants/kbl/hda_verb.c
View file

@ -27,47 +27,47 @@ const u32 cim_verb_data[] = {
AZALIA_SUBVENDOR(0, 0x1e507038),
AZALIA_PIN_CFG(0, 0x01, 0x00000000),
AZALIA_PIN_CFG(0, DMIC, AZALIA_PIN_DESC( \
AZALIA_INTEGRATED, \
AZALIA_INTERNAL | AZALIA_TOP, \
AZALIA_MIC_IN, \
AZALIA_TYPE_UNKNOWN, \
AZALIA_BLACK, \
AZALIA_JACK_PRESENCE_DETECT, \
3, \
0 \
AZALIA_PIN_CFG(0, DMIC, AZALIA_PIN_DESC(
AZALIA_INTEGRATED,
AZALIA_MOBILE_LID_INSIDE,
AZALIA_MIC_IN,
AZALIA_OTHER_DIGITAL,
AZALIA_COLOR_UNKNOWN,
AZALIA_NO_JACK_PRESENCE_DETECT,
3,
0
)),
AZALIA_PIN_CFG(0, SPEAKERS, AZALIA_PIN_DESC( \
AZALIA_INTEGRATED, \
AZALIA_INTERNAL | AZALIA_FRONT, \
AZALIA_SPEAKER, \
AZALIA_TYPE_UNKNOWN, \
AZALIA_BLACK, \
AZALIA_JACK_PRESENCE_DETECT, \
1, \
0 \
AZALIA_PIN_CFG(0, SPEAKERS, AZALIA_PIN_DESC(
AZALIA_INTEGRATED,
AZALIA_INTERNAL | AZALIA_FRONT,
AZALIA_SPEAKER,
AZALIA_OTHER_ANALOG,
AZALIA_COLOR_UNKNOWN,
AZALIA_NO_JACK_PRESENCE_DETECT,
1,
0
)),
AZALIA_PIN_CFG(0, HEADPHONE, AZALIA_PIN_DESC( \
AZALIA_JACK, \
AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, \
AZALIA_HP_OUT, \
AZALIA_STEREO_MONO_1_8, \
AZALIA_BLACK, \
AZALIA_JACK_PRESENCE_DETECT, \
2, \
0 \
AZALIA_PIN_CFG(0, HEADPHONE, AZALIA_PIN_DESC(
AZALIA_JACK,
AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT,
AZALIA_HP_OUT,
AZALIA_STEREO_MONO_1_8,
AZALIA_BLACK,
AZALIA_JACK_PRESENCE_DETECT,
2,
0
)),
AZALIA_PIN_CFG(0, MONO, AZALIA_PIN_CFG_NC(0)),
AZALIA_PIN_CFG(0, MIC1, AZALIA_PIN_DESC( \
AZALIA_JACK, \
AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, \
AZALIA_MIC_IN, \
AZALIA_STEREO_MONO_1_8, \
AZALIA_BLACK, \
AZALIA_JACK_PRESENCE_DETECT, \
4, \
0 \
AZALIA_PIN_CFG(0, MIC1, AZALIA_PIN_DESC(
AZALIA_JACK,
AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT,
AZALIA_MIC_IN,
AZALIA_STEREO_MONO_1_8,
AZALIA_BLACK,
AZALIA_JACK_PRESENCE_DETECT,
4,
0
)),
AZALIA_PIN_CFG(0, MIC2, AZALIA_PIN_CFG_NC(0)),
AZALIA_PIN_CFG(0, LINE1, AZALIA_PIN_CFG_NC(0)),