From 5e2f5050ba29a7c40cd0f1e04b3713e339b965ff Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Thu, 4 Sep 2025 11:01:32 -0500 Subject: [PATCH] mb/starlabs/starbook/kbl: Update HDA verb table Remove presence detection flag for the DMIC and internal speakers. While we're at it, fix the (non-functional) descriptive flags for those two verbs as well. Remove unnecessary line continuations. TEST=build/boot Win11 and Linux on Starbook KBL, verify speaker and intermal mic working, as well as headphones/jack mic when plugged in. Change-Id: I4d4a41736faac944b3165a56fe5846f24c20f549 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/89044 Tested-by: build bot (Jenkins) Reviewed-by: Sean Rhodes --- .../starlabs/starbook/variants/kbl/hda_verb.c | 72 +++++++++---------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/kbl/hda_verb.c b/src/mainboard/starlabs/starbook/variants/kbl/hda_verb.c index 7da0991336..82071822a4 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/hda_verb.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/hda_verb.c @@ -27,47 +27,47 @@ const u32 cim_verb_data[] = { AZALIA_SUBVENDOR(0, 0x1e507038), AZALIA_PIN_CFG(0, 0x01, 0x00000000), - AZALIA_PIN_CFG(0, DMIC, AZALIA_PIN_DESC( \ - AZALIA_INTEGRATED, \ - AZALIA_INTERNAL | AZALIA_TOP, \ - AZALIA_MIC_IN, \ - AZALIA_TYPE_UNKNOWN, \ - AZALIA_BLACK, \ - AZALIA_JACK_PRESENCE_DETECT, \ - 3, \ - 0 \ + AZALIA_PIN_CFG(0, DMIC, AZALIA_PIN_DESC( + AZALIA_INTEGRATED, + AZALIA_MOBILE_LID_INSIDE, + AZALIA_MIC_IN, + AZALIA_OTHER_DIGITAL, + AZALIA_COLOR_UNKNOWN, + AZALIA_NO_JACK_PRESENCE_DETECT, + 3, + 0 )), - AZALIA_PIN_CFG(0, SPEAKERS, AZALIA_PIN_DESC( \ - AZALIA_INTEGRATED, \ - AZALIA_INTERNAL | AZALIA_FRONT, \ - AZALIA_SPEAKER, \ - AZALIA_TYPE_UNKNOWN, \ - AZALIA_BLACK, \ - AZALIA_JACK_PRESENCE_DETECT, \ - 1, \ - 0 \ + AZALIA_PIN_CFG(0, SPEAKERS, AZALIA_PIN_DESC( + AZALIA_INTEGRATED, + AZALIA_INTERNAL | AZALIA_FRONT, + AZALIA_SPEAKER, + AZALIA_OTHER_ANALOG, + AZALIA_COLOR_UNKNOWN, + AZALIA_NO_JACK_PRESENCE_DETECT, + 1, + 0 )), - AZALIA_PIN_CFG(0, HEADPHONE, AZALIA_PIN_DESC( \ - AZALIA_JACK, \ - AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, \ - AZALIA_HP_OUT, \ - AZALIA_STEREO_MONO_1_8, \ - AZALIA_BLACK, \ - AZALIA_JACK_PRESENCE_DETECT, \ - 2, \ - 0 \ + AZALIA_PIN_CFG(0, HEADPHONE, AZALIA_PIN_DESC( + AZALIA_JACK, + AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, + AZALIA_HP_OUT, + AZALIA_STEREO_MONO_1_8, + AZALIA_BLACK, + AZALIA_JACK_PRESENCE_DETECT, + 2, + 0 )), AZALIA_PIN_CFG(0, MONO, AZALIA_PIN_CFG_NC(0)), - AZALIA_PIN_CFG(0, MIC1, AZALIA_PIN_DESC( \ - AZALIA_JACK, \ - AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, \ - AZALIA_MIC_IN, \ - AZALIA_STEREO_MONO_1_8, \ - AZALIA_BLACK, \ - AZALIA_JACK_PRESENCE_DETECT, \ - 4, \ - 0 \ + AZALIA_PIN_CFG(0, MIC1, AZALIA_PIN_DESC( + AZALIA_JACK, + AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, + AZALIA_MIC_IN, + AZALIA_STEREO_MONO_1_8, + AZALIA_BLACK, + AZALIA_JACK_PRESENCE_DETECT, + 4, + 0 )), AZALIA_PIN_CFG(0, MIC2, AZALIA_PIN_CFG_NC(0)), AZALIA_PIN_CFG(0, LINE1, AZALIA_PIN_CFG_NC(0)),