erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/pantherlake: Fix UFS ACPI inclusion in southbridge.asl

Browse source 
This patch corrects the conditional inclusion of the `ufs.asl` file in
the southbridge ACPI configuration.

Previously, the inclusion of `ufs.asl` was incorrectly dependent on the
`MAINBOARD_USES_IFD_GBE_REGION` Kconfig option. This prevented the UFS
ACPI entry from being included in the DSDT when
`MAINBOARD_USES_IFD_GBE_REGION` was disabled, causing issues with
booting from UFS media.

This commit fixes the issue by ensuring that `ufs.asl` is included
based on the `SOC_INTEL_PANTHERLAKE_U_H` Kconfig option, which correctly
reflects the presence of UFS hardware.

This change ensures that the UFS ACPI device is correctly enumerated and
available to the operating system.

BUG=b:382243957
TEST=Able to verify UFS ACPI device is available inside DSDT table.

Change-Id: Ic8e87c57dd2db30f0ba13ac0a9f7fd2db877039a
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85526
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
This commit is contained in:
Subrata Banik 2024-12-07 09:11:44 +05:30
commit 5b447d00f5
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/soc/intel/pantherlake/acpi/southbridge.asl
View file

@ -47,10 +47,9 @@
/* GbE 0:1f.6 */
#if CONFIG(MAINBOARD_USES_IFD_GBE_REGION)
#include <soc/intel/common/block/acpi/acpi/pch_glan.asl>
#endif
/* UFS 0:17:0 */
#if CONFIG(SOC_INTEL_PANTHERLAKE_U_H)
#include <soc/intel/common/block/acpi/acpi/ufs.asl>
#endif
#endif