From 5b447d00f5a1b17a8b195fca89302b6a090ba446 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Sat, 7 Dec 2024 09:11:44 +0530 Subject: [PATCH] soc/intel/pantherlake: Fix UFS ACPI inclusion in southbridge.asl This patch corrects the conditional inclusion of the `ufs.asl` file in the southbridge ACPI configuration. Previously, the inclusion of `ufs.asl` was incorrectly dependent on the `MAINBOARD_USES_IFD_GBE_REGION` Kconfig option. This prevented the UFS ACPI entry from being included in the DSDT when `MAINBOARD_USES_IFD_GBE_REGION` was disabled, causing issues with booting from UFS media. This commit fixes the issue by ensuring that `ufs.asl` is included based on the `SOC_INTEL_PANTHERLAKE_U_H` Kconfig option, which correctly reflects the presence of UFS hardware. This change ensures that the UFS ACPI device is correctly enumerated and available to the operating system. BUG=b:382243957 TEST=Able to verify UFS ACPI device is available inside DSDT table. Change-Id: Ic8e87c57dd2db30f0ba13ac0a9f7fd2db877039a Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/85526 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas Reviewed-by: Kapil Porwal --- src/soc/intel/pantherlake/acpi/southbridge.asl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/soc/intel/pantherlake/acpi/southbridge.asl b/src/soc/intel/pantherlake/acpi/southbridge.asl index c047a71b8c..a6cdda3076 100644 --- a/src/soc/intel/pantherlake/acpi/southbridge.asl +++ b/src/soc/intel/pantherlake/acpi/southbridge.asl @@ -47,10 +47,9 @@ /* GbE 0:1f.6 */ #if CONFIG(MAINBOARD_USES_IFD_GBE_REGION) #include +#endif /* UFS 0:17:0 */ #if CONFIG(SOC_INTEL_PANTHERLAKE_U_H) #include #endif - -#endif