erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

kirby: Enable the internal pull up on the recovery mode pin.

Browse source 
The recovery mode pin has no external pull up and will float low, turning on
recovery mode even though nobody asked for it. We should enable the internal
pull up so that it doesn't float around.

BUG=None
TEST=Built and booted into depthcharge on kirby. Saw that a manual recovery
mode request was no longer detected. Now we end up in recovery mode because
we have no disk.
BRANCH=None

Change-Id: Ic9c5d7ea4b584e770030cdf5dbb1fa37f0344db8
Signed-off-by: Gabe Black <gabeblack@google.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/66880
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Commit-Queue: Gabe Black <gabeblack@chromium.org>
Tested-by: Gabe Black <gabeblack@chromium.org>
This commit is contained in:
Gabe Black 2013-08-23 16:20:08 -07:00 • committed by ChromeBot
commit 594a58f9b2
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/mainboard/google/kirby/romstage.c
View file

@ -122,7 +122,7 @@ static void setup_gpio(void)
gpio_set_pull(GPIO_X30, GPIO_PULL_NONE);
gpio_direction_input(GPIO_X07); // RECMODE_GPIO
gpio_set_pull(GPIO_X07, GPIO_PULL_NONE);
gpio_set_pull(GPIO_X07, GPIO_PULL_UP);
gpio_direction_input(GPIO_X34); // LID_GPIO
gpio_set_pull(GPIO_X34, GPIO_PULL_NONE);