From 594a58f9b233509ac05475bfd1e502ca03d60a7e Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Fri, 23 Aug 2013 16:20:08 -0700 Subject: [PATCH] kirby: Enable the internal pull up on the recovery mode pin. The recovery mode pin has no external pull up and will float low, turning on recovery mode even though nobody asked for it. We should enable the internal pull up so that it doesn't float around. BUG=None TEST=Built and booted into depthcharge on kirby. Saw that a manual recovery mode request was no longer detected. Now we end up in recovery mode because we have no disk. BRANCH=None Change-Id: Ic9c5d7ea4b584e770030cdf5dbb1fa37f0344db8 Signed-off-by: Gabe Black Reviewed-on: https://gerrit.chromium.org/gerrit/66880 Reviewed-by: David Hendricks Commit-Queue: Gabe Black Tested-by: Gabe Black --- src/mainboard/google/kirby/romstage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/google/kirby/romstage.c b/src/mainboard/google/kirby/romstage.c index 841b6214e4..cb5552abc6 100644 --- a/src/mainboard/google/kirby/romstage.c +++ b/src/mainboard/google/kirby/romstage.c @@ -122,7 +122,7 @@ static void setup_gpio(void) gpio_set_pull(GPIO_X30, GPIO_PULL_NONE); gpio_direction_input(GPIO_X07); // RECMODE_GPIO - gpio_set_pull(GPIO_X07, GPIO_PULL_NONE); + gpio_set_pull(GPIO_X07, GPIO_PULL_UP); gpio_direction_input(GPIO_X34); // LID_GPIO gpio_set_pull(GPIO_X34, GPIO_PULL_NONE);