erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/cmn/cnvi: Drop CNIP ACPI method

Browse source 
This method is used in the Intel/AMI reference code to verify
that the device is present (vendor ID != 0xFFFFFFFF), but that's
neither used nor needed here, as coreboot only generates SSDT
code for devices which are actually present.

TEST=build/boot Linux, verify no ACPI issues after dropping

Change-Id: Ib60c48852923e965620f4eee6a886c8c0f5c1783
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86091
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
This commit is contained in:
Matt DeVillier 2025-01-21 15:17:31 -06:00 • committed by Sean Rhodes
commit 4ee42d8792
1 changed files with 0 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/soc/intel/common/block/cnvi/cnvi.c
View file

@ -358,31 +358,6 @@ static void cnvw_fill_ssdt(const struct device *dev)
acpigen_pop_len();
}
acpigen_pop_len();
/*
* Method (CNIP, 0, NotSerialized)
* {
* If (^CNVW.VDID == 0xFFFFFFFF)
* {
* Return (Zero)
* } Else {
* Return (One)
* }
* }
*/
acpigen_write_method("CNIP", 0);
{
acpigen_write_if_lequal_namestr_int("^CNVW.VDID", 0xffffffff);
{
acpigen_write_return_integer(0);
}
acpigen_write_else();
{
acpigen_write_return_integer(1);
}
acpigen_pop_len();
}
acpigen_pop_len();
}
static struct device_operations cnvi_wifi_ops = {