From 4ee42d8792ccdfea64f2c965f92766d7607e7f00 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Tue, 21 Jan 2025 15:17:31 -0600 Subject: [PATCH] soc/intel/cmn/cnvi: Drop CNIP ACPI method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This method is used in the Intel/AMI reference code to verify that the device is present (vendor ID != 0xFFFFFFFF), but that's neither used nor needed here, as coreboot only generates SSDT code for devices which are actually present. TEST=build/boot Linux, verify no ACPI issues after dropping Change-Id: Ib60c48852923e965620f4eee6a886c8c0f5c1783 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/86091 Reviewed-by: Sean Rhodes Tested-by: build bot (Jenkins) Reviewed-by: Jérémy Compostella --- src/soc/intel/common/block/cnvi/cnvi.c | 25 ------------------------- 1 file changed, 25 deletions(-) diff --git a/src/soc/intel/common/block/cnvi/cnvi.c b/src/soc/intel/common/block/cnvi/cnvi.c index 5e75f6d492..301fb3a4ee 100644 --- a/src/soc/intel/common/block/cnvi/cnvi.c +++ b/src/soc/intel/common/block/cnvi/cnvi.c @@ -358,31 +358,6 @@ static void cnvw_fill_ssdt(const struct device *dev) acpigen_pop_len(); } acpigen_pop_len(); - -/* - * Method (CNIP, 0, NotSerialized) - * { - * If (^CNVW.VDID == 0xFFFFFFFF) - * { - * Return (Zero) - * } Else { - * Return (One) - * } - * } - */ - acpigen_write_method("CNIP", 0); - { - acpigen_write_if_lequal_namestr_int("^CNVW.VDID", 0xffffffff); - { - acpigen_write_return_integer(0); - } - acpigen_write_else(); - { - acpigen_write_return_integer(1); - } - acpigen_pop_len(); - } - acpigen_pop_len(); } static struct device_operations cnvi_wifi_ops = {