erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

util/amdfwtool/amdfwread.c: Remove APOB_NV special case

Browse source 
There is no need to treat the APOB_NV binary special anymore, as
the mode and address should now always match for the APOB_NV address.
Since phoenix SOC generation this code even errors out on VBOOT
platforms, because APOB_NV address is actually a BIOS relative address.

Signed-off-by: Maximilian Brune <maximilian.brune@9elements.com>
Change-Id: I64d43e654e3694d7590edcba9a87c98367a7256c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87297
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Maximilian Brune 2025-04-12 16:37:30 +02:00 • committed by Matt DeVillier
commit 4a99023e0f
1 changed files with 0 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
util/amdfwtool/amdfwread.c
View file

@ -262,11 +262,6 @@ static int amdfw_bios_dir_walk(FILE *fw, uint32_t bios_offset, uint32_t cookie,
printf("%sBIOS%s: 0x%02x 0x%lx(DRAM-Address)\n",
indent, cookie == BHD_COOKIE ? "L1" : "L2",
type, current_entries[i].dest);
else if (type == AMD_BIOS_APOB_NV)
printf("%sBIOS%s: 0x%02x 0x%08lx 0x%08x\n",
indent, cookie == BHD_COOKIE ? "L1" : "L2",
type, relative_offset(bios_offset, addr, AMD_ADDR_PHYSICAL),
current_entries[i].size);
else
printf("%sBIOS%s: 0x%02x 0x%08lx 0x%08x\n",
indent, cookie == BHD_COOKIE ? "L1" : "L2",