From 4a99023e0fcf3000ec89f7bf4cce2c0ae53d51b2 Mon Sep 17 00:00:00 2001 From: Maximilian Brune Date: Sat, 12 Apr 2025 16:37:30 +0200 Subject: [PATCH] util/amdfwtool/amdfwread.c: Remove APOB_NV special case There is no need to treat the APOB_NV binary special anymore, as the mode and address should now always match for the APOB_NV address. Since phoenix SOC generation this code even errors out on VBOOT platforms, because APOB_NV address is actually a BIOS relative address. Signed-off-by: Maximilian Brune Change-Id: I64d43e654e3694d7590edcba9a87c98367a7256c Reviewed-on: https://review.coreboot.org/c/coreboot/+/87297 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- util/amdfwtool/amdfwread.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/util/amdfwtool/amdfwread.c b/util/amdfwtool/amdfwread.c index ca61571602..4dd3b0f770 100644 --- a/util/amdfwtool/amdfwread.c +++ b/util/amdfwtool/amdfwread.c @@ -262,11 +262,6 @@ static int amdfw_bios_dir_walk(FILE *fw, uint32_t bios_offset, uint32_t cookie, printf("%sBIOS%s: 0x%02x 0x%lx(DRAM-Address)\n", indent, cookie == BHD_COOKIE ? "L1" : "L2", type, current_entries[i].dest); - else if (type == AMD_BIOS_APOB_NV) - printf("%sBIOS%s: 0x%02x 0x%08lx 0x%08x\n", - indent, cookie == BHD_COOKIE ? "L1" : "L2", - type, relative_offset(bios_offset, addr, AMD_ADDR_PHYSICAL), - current_entries[i].size); else printf("%sBIOS%s: 0x%02x 0x%08lx 0x%08x\n", indent, cookie == BHD_COOKIE ? "L1" : "L2",