erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

broadwell: acpi: Clean up acpi table creation code

Browse source 
- Fix header includes
- Use ACPI_BASE_ADDRESS instead of get_pmbase()
- Remove chip_operations as those are now in chip.c

BUG=chrome-os-partner:28234
TEST=None

Change-Id: I28712275a46b64941796bca46ec1bd648b8178f6
Signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/199408
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Duncan Laurie 2014-05-02 15:12:48 -07:00 • committed by chrome-internal-fetch
commit 49088b312b
1 changed files with 20 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

34
src/soc/intel/broadwell/acpi.c
View file

@ -18,21 +18,30 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
#include <types.h>
#include <console/console.h>
#include <arch/acpi.h>
#include <arch/acpigen.h>
#include <arch/io.h>
#include <arch/smp/mpspec.h>
#include <cbmem.h>
#include <console/console.h>
#include <cpu/x86/smm.h>
#include <console/console.h>
#include <types.h>
#include <string.h>
#include <arch/cpu.h>
#include <cpu/x86/msr.h>
#include <cpu/intel/speedstep.h>
#include <cpu/x86/tsc.h>
#include <cpu/intel/turbo.h>
#include <device/device.h>
#include <device/pci.h>
#include "haswell.h"
#include "chip.h"
#include <southbridge/intel/lynxpoint/pch.h>
#include <ec/google/chromeec/ec.h>
#include <vendorcode/google/chromeos/gnvs.h>
#include <broadwell/acpi.h>
#include <broadwell/cpu.h>
#include <broadwell/iomap.h>
#include <broadwell/lpc.h>
#include <broadwell/msr.h>
#include <broadwell/pci_devs.h>
#include <broadwell/pm.h>
#include <chip.h>
/*
* List of suported C-states in this processor. Only the ULT parts support C8,
@ -477,7 +486,7 @@ static int generate_P_state_entries(int core, int cores_per_package)
void generate_cpu_entries(void)
{
int len_pr;
int coreID, cpuID, pcontrol_blk = get_pmbase(), plen = 6;
int coreID, cpuID, pcontrol_blk = ACPI_BASE_ADDRESS, plen = 6;
int totalcores = dev_count_cpu();
int cores_per_package = get_cores_per_package();
int numcpus = totalcores/cores_per_package;
@ -514,6 +523,3 @@ void generate_cpu_entries(void)
}
}
struct chip_operations cpu_intel_haswell_ops = {
CHIP_NAME("Intel Haswell CPU")
};