erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

peppy and falco: set panel power timings in northbridge, using devicetree, not mainboards

Browse source 
Historically we had set panel timing in the mainboard gma code. This goes
back to the replay-attack video startup.

We can let the haswell gma code set these values from the device tree
settings.

BUG=None
TEST=Build and boot with this change.
BRANCH=None

Change-Id: If32150d2857241ca2d2c88880086f49d25815d76
Signed-off-by: Ronald G. Minnich <rminnich@google.com>
Reviewed-on: https://chromium-review.googlesource.com/180521
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Commit-Queue: Ronald Minnich <rminnich@chromium.org>
Tested-by: Ronald Minnich <rminnich@chromium.org>
This commit is contained in:
Ronald G. Minnich 2013-12-17 15:21:54 -08:00 • committed by chrome-internal-fetch
commit 406eab3ca6
3 changed files with 0 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/mainboard/google/falco/gma.c
View file

@ -191,9 +191,6 @@ int panel_lightup(struct intel_dp *dp, unsigned int init_fb)
/* These values are used for training the link */
dp->lane_count = 2;
dp->link_bw = DP_LINK_BW_2_7;
dp->panel_power_down_delay = 600;
dp->panel_power_up_delay = 200;
dp->panel_power_cycle_delay = 600;
dp->pipe = PIPE_A;
dp->port = PORT_A;
dp->plane = PLANE_A;

5
src/mainboard/google/peppy/gma.c
View file

@ -216,11 +216,6 @@ int panel_lightup(struct intel_dp *dp, unsigned int init_fb)
dp->aux_clock_divider = 0xe1;
dp->precharge = 3;
/* CRAP -- needs to be done elsewhere from the device tree. */
dp->panel_power_down_delay = 600;
dp->panel_power_up_delay = 200;
dp->panel_power_cycle_delay = 600;
/* 1. Normal mode: Set the first page to zero and make
all GTT entries point to the same page
2. Developer/Recovery mode: Set up a tasteful color

1
src/northbridge/intel/haswell/gma.c
View file

@ -458,7 +458,6 @@ static void gma_func0_init(struct device *dev)
dp.panel_power_up_delay = conf->gpu_panel_power_up_delay;
dp.panel_power_cycle_delay = conf->gpu_panel_power_cycle_delay;
dp.physbase = pci_read_config32(dev, 0x5c) & ~0xf;
#ifdef CONFIG_CHROMEOS
init_fb = developer_mode_enabled() || recovery_mode_enabled();
#endif