From 406eab3ca6a9bc59382866817786bf96bbb19d56 Mon Sep 17 00:00:00 2001 From: "Ronald G. Minnich" Date: Tue, 17 Dec 2013 15:21:54 -0800 Subject: [PATCH] peppy and falco: set panel power timings in northbridge, using devicetree, not mainboards Historically we had set panel timing in the mainboard gma code. This goes back to the replay-attack video startup. We can let the haswell gma code set these values from the device tree settings. BUG=None TEST=Build and boot with this change. BRANCH=None Change-Id: If32150d2857241ca2d2c88880086f49d25815d76 Signed-off-by: Ronald G. Minnich Reviewed-on: https://chromium-review.googlesource.com/180521 Reviewed-by: Aaron Durbin Commit-Queue: Ronald Minnich Tested-by: Ronald Minnich --- src/mainboard/google/falco/gma.c | 3 --- src/mainboard/google/peppy/gma.c | 5 ----- src/northbridge/intel/haswell/gma.c | 1 - 3 files changed, 9 deletions(-) diff --git a/src/mainboard/google/falco/gma.c b/src/mainboard/google/falco/gma.c index dcf488e7a3..2c5f7765b6 100644 --- a/src/mainboard/google/falco/gma.c +++ b/src/mainboard/google/falco/gma.c @@ -191,9 +191,6 @@ int panel_lightup(struct intel_dp *dp, unsigned int init_fb) /* These values are used for training the link */ dp->lane_count = 2; dp->link_bw = DP_LINK_BW_2_7; - dp->panel_power_down_delay = 600; - dp->panel_power_up_delay = 200; - dp->panel_power_cycle_delay = 600; dp->pipe = PIPE_A; dp->port = PORT_A; dp->plane = PLANE_A; diff --git a/src/mainboard/google/peppy/gma.c b/src/mainboard/google/peppy/gma.c index feacbf2da2..08111a354f 100644 --- a/src/mainboard/google/peppy/gma.c +++ b/src/mainboard/google/peppy/gma.c @@ -216,11 +216,6 @@ int panel_lightup(struct intel_dp *dp, unsigned int init_fb) dp->aux_clock_divider = 0xe1; dp->precharge = 3; - /* CRAP -- needs to be done elsewhere from the device tree. */ - dp->panel_power_down_delay = 600; - dp->panel_power_up_delay = 200; - dp->panel_power_cycle_delay = 600; - /* 1. Normal mode: Set the first page to zero and make all GTT entries point to the same page 2. Developer/Recovery mode: Set up a tasteful color diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 58c5c02e5f..8055531df4 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -458,7 +458,6 @@ static void gma_func0_init(struct device *dev) dp.panel_power_up_delay = conf->gpu_panel_power_up_delay; dp.panel_power_cycle_delay = conf->gpu_panel_power_cycle_delay; - dp.physbase = pci_read_config32(dev, 0x5c) & ~0xf; #ifdef CONFIG_CHROMEOS init_fb = developer_mode_enabled() || recovery_mode_enabled(); #endif