erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/protectli/vault_ehl/devicetree.cb: Fix assertion in soc/pmutil

Browse source 
The SoC code requires for GPE DW config values to be different.
Assign the default values of PMC GPIO_CONF register as GPIO GPEs
are not used on this platform. Fixes the assertion in
soc/intel/elkhartalke/pmutil.

TEST=Boot Protectli VP2420 to Ubuntu 24.04.

Change-Id: Ibf4a1f52bf970c27d0ca8dd1b1377d6a5e6477f9
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87049
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Michał Żygowski 2025-03-31 15:31:57 +02:00 • committed by Felix Held
commit 3c0fe9ef3b
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/mainboard/protectli/vault_ehl/devicetree.cb
View file

@ -18,9 +18,9 @@ chip soc/intel/elkhartlake
# route, i.e., if this route changes then the affected GPE
# offset bits also need to be changed. This sets the PMC register
# GPE_CFG fields.
#register "pmc_gpe0_dw1" = "PMC_GPE_SCC_63_32"
#register "pmc_gpe0_dw2" = "PMC_GPE_N_31_0"
#register "pmc_gpe0_dw3" = "PMC_GPE_SCC_31_0"
register "pmc_gpe0_dw0" = "PMC_GPP_A"
register "pmc_gpe0_dw1" = "PMC_GPP_R"
register "pmc_gpe0_dw2" = "PMC_GPD"
register "tcc_offset" = "5" # TCC of 95C