erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/brox: Reduce PL4 only for battery disconnected scenario

Browse source 
This patch reduces PL4 only for no battery condition i.e. when battery
is disconnected or not physically present.

BUG=b:377305625
TEST=Build Brox and boot when the battery is disconnected

Change-Id: I59a1028ce9cd3a6cf98f865d9c085a64f391f201
Signed-off-by: Sowmya Aralguppe <sowmya.aralguppe@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85002
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
This commit is contained in:
Sowmya Aralguppe 2024-11-05 16:55:11 +05:30 • committed by Karthik Ramasubramanian
commit 34cbfae8b6
2 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/mainboard/google/brox/romstage.c
View file

@ -21,8 +21,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
size_t pads_num;
/* If battery is not present - Boot with maximum non-turbo frequency */
if (CONFIG(EC_GOOGLE_CHROMEEC) &&
!google_chromeec_is_battery_present_and_above_critical_threshold()) {
if (CONFIG(EC_GOOGLE_CHROMEEC) && !google_chromeec_is_battery_present()) {
FSP_M_CONFIG *mem_cfg = &memupd->FspmConfig;
mem_cfg->BootFrequency = MAX_NONTURBO_PERFORMANCE;
printk(BIOS_DEBUG, "Boot Frequency is set to %u\n", mem_cfg->BootFrequency);

5
src/mainboard/google/brox/variants/baseboard/brox/ramstage.c
View file

@ -53,9 +53,8 @@ static void variant_pl4_override(struct soc_power_limits_config *config,
if (!config->tdp_pl4)
return;
/* limiting PL4 value for battery disconnected or below critical threshold */
if (CONFIG_PL4_LIMIT_FOR_CRITICAL_BAT_BOOT &&
(!google_chromeec_is_battery_present_and_above_critical_threshold()))
/* Limit PL4 when battery is disconnected */
if (CONFIG_PL4_LIMIT_FOR_CRITICAL_BAT_BOOT && !google_chromeec_is_battery_present())
config->tdp_pl4 = CONFIG_PL4_LIMIT_FOR_CRITICAL_BAT_BOOT;
else
config->tdp_pl4 = DIV_ROUND_UP(limits[brox_idx].pl4_power, MILLIWATTS_TO_WATTS);