From 34cbfae8b6d01c7dcbaba6891ec2f4ffb234efc3 Mon Sep 17 00:00:00 2001 From: Sowmya Aralguppe Date: Tue, 5 Nov 2024 16:55:11 +0530 Subject: [PATCH] mb/google/brox: Reduce PL4 only for battery disconnected scenario This patch reduces PL4 only for no battery condition i.e. when battery is disconnected or not physically present. BUG=b:377305625 TEST=Build Brox and boot when the battery is disconnected Change-Id: I59a1028ce9cd3a6cf98f865d9c085a64f391f201 Signed-off-by: Sowmya Aralguppe Reviewed-on: https://review.coreboot.org/c/coreboot/+/85002 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian --- src/mainboard/google/brox/romstage.c | 3 +-- src/mainboard/google/brox/variants/baseboard/brox/ramstage.c | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/mainboard/google/brox/romstage.c b/src/mainboard/google/brox/romstage.c index ced918457d..19b99bbeb7 100644 --- a/src/mainboard/google/brox/romstage.c +++ b/src/mainboard/google/brox/romstage.c @@ -21,8 +21,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd) size_t pads_num; /* If battery is not present - Boot with maximum non-turbo frequency */ - if (CONFIG(EC_GOOGLE_CHROMEEC) && - !google_chromeec_is_battery_present_and_above_critical_threshold()) { + if (CONFIG(EC_GOOGLE_CHROMEEC) && !google_chromeec_is_battery_present()) { FSP_M_CONFIG *mem_cfg = &memupd->FspmConfig; mem_cfg->BootFrequency = MAX_NONTURBO_PERFORMANCE; printk(BIOS_DEBUG, "Boot Frequency is set to %u\n", mem_cfg->BootFrequency); diff --git a/src/mainboard/google/brox/variants/baseboard/brox/ramstage.c b/src/mainboard/google/brox/variants/baseboard/brox/ramstage.c index 80c8499e4e..f079d7a58f 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/ramstage.c +++ b/src/mainboard/google/brox/variants/baseboard/brox/ramstage.c @@ -53,9 +53,8 @@ static void variant_pl4_override(struct soc_power_limits_config *config, if (!config->tdp_pl4) return; - /* limiting PL4 value for battery disconnected or below critical threshold */ - if (CONFIG_PL4_LIMIT_FOR_CRITICAL_BAT_BOOT && - (!google_chromeec_is_battery_present_and_above_critical_threshold())) + /* Limit PL4 when battery is disconnected */ + if (CONFIG_PL4_LIMIT_FOR_CRITICAL_BAT_BOOT && !google_chromeec_is_battery_present()) config->tdp_pl4 = CONFIG_PL4_LIMIT_FOR_CRITICAL_BAT_BOOT; else config->tdp_pl4 = DIV_ROUND_UP(limits[brox_idx].pl4_power, MILLIWATTS_TO_WATTS);