erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/starlabs/starlite_adl/acpi: Fix _GPE callback type

Browse source 
The GPIO which is used to determine whether the keyboard is connected
or not is dual-edge triggered, not level triggered, so adjust the
method name to reflect that. This ensures that the keyboard status
is updated on both connection and disconnection.

TEST=build/boot starlite_adl, verify tablet mode is correctly detected
when the keyboard is detached under both Windows and Linux.

Change-Id: I6c539fa264a2910589846e58d851acbe7c00900e
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87993
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
This commit is contained in:
Matt DeVillier 2025-06-06 18:42:35 -05:00 • committed by Sean Rhodes
commit 26fd33a92a
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/mainboard/starlabs/starlite_adl/acpi/mainboard.asl
View file

@ -6,7 +6,7 @@ Scope (\_SB) {
Scope (_GPE)
{
Method (_L0F, 0, NotSerialized)
Method (_E0F, 0, NotSerialized)
{
\_SB.PCI0.LPCB.EC.VBTN.UPDK()
}