erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/dedede: Fix/Clean up IPU/MIPI camera settings

Browse source 
- Add IPUA device under igpu (gfx/generic) for variants with IPU:
  bugzzy, drawcia, haboki, lalala, magolor, storo, waddledoo
- Set ssdb.link_used to match cio2_prt
- Drop ssdb.rom_type and rom_address from mipi_camera sensor nodes;
  JSL doesn't use this, and it causes a BSOD under Windows
- Add missing sensor_name for CAMERA_SENSOR on magolor and waddledoo

TEST=build/boot Win11 on magolor, verify MIPI camera functional

Change-Id: I7fca3c6bb8bca9271a4dbaf888cc28304d6545a8
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/91066
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Matt DeVillier 2026-02-02 13:48:24 -06:00
commit 1fb063c0da
7 changed files with 45 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/mainboard/google/dedede/variants/bugzzy/overridetree.cb
View file

@ -96,11 +96,15 @@ chip soc/intel/jasperlake
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "1"
register "device_count" = "2"
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].type" = "panel"
# IPUA for IPUs
register "device[1].name" = ""IPUA""
register "device[1].non_vga_device" = "true"
register "device[1].addr" = "0x3480"
device generic 0 on end
end
@ -257,13 +261,11 @@ chip soc/intel/jasperlake
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "ssdb.lanes_used" = "4"
register "ssdb.link_used" = "1"
register "ssdb.link_used" = "2"
register "ssdb.platform" = "PLAT_JSL"
register "ssdb.vcm_type" = "VCM_DW9714"
register "vcm_address" = "0x0C"
register "vcm_name" = ""VCM0""
register "ssdb.rom_type" = "ROM_EEPROM_CAT24C08"
register "rom_address" = "0x50"
register "num_freq_entries" = "2"
register "link_freq[0]" = "360000000"
register "link_freq[1]" = "180000000"

10
src/mainboard/google/dedede/variants/drawcia/overridetree.cb
View file

@ -84,11 +84,15 @@ chip soc/intel/jasperlake
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "1"
register "device_count" = "2"
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].type" = "panel"
# IPUA for IPUs
register "device[1].name" = ""IPUA""
register "device[1].non_vga_device" = "true"
register "device[1].addr" = "0x3480"
device generic 0 on end
end
@ -317,13 +321,11 @@ chip soc/intel/jasperlake
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "ssdb.lanes_used" = "4"
register "ssdb.link_used" = "1"
register "ssdb.link_used" = "2"
register "ssdb.platform" = "PLAT_JSL"
register "ssdb.vcm_type" = "VCM_DW9714"
register "vcm_address" = "0x0C"
register "vcm_name" = ""VCM0""
register "ssdb.rom_type" = "ROM_EEPROM_CAT24C08"
register "rom_address" = "0x50"
register "num_freq_entries" = "2"
register "link_freq[0]" = "360000000"
register "link_freq[1]" = "180000000"

10
src/mainboard/google/dedede/variants/haboki/overridetree.cb
View file

@ -55,11 +55,15 @@ chip soc/intel/jasperlake
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "1"
register "device_count" = "2"
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].type" = "panel"
# IPUA for IPUs
register "device[1].name" = ""IPUA""
register "device[1].non_vga_device" = "true"
register "device[1].addr" = "0x3480"
device generic 0 on end
end
@ -231,13 +235,11 @@ chip soc/intel/jasperlake
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "ssdb.lanes_used" = "4"
register "ssdb.link_used" = "1"
register "ssdb.link_used" = "2"
register "ssdb.platform" = "PLAT_JSL"
register "ssdb.vcm_type" = "VCM_DW9714"
register "vcm_address" = "0x0C"
register "vcm_name" = ""VCM0""
register "ssdb.rom_type" = "ROM_EEPROM_CAT24C08"
register "rom_address" = "0x50"
register "num_freq_entries" = "2"
register "link_freq[0]" = "360000000"
register "link_freq[1]" = "180000000"

10
src/mainboard/google/dedede/variants/lalala/overridetree.cb
View file

@ -89,11 +89,15 @@ chip soc/intel/jasperlake
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "1"
register "device_count" = "2"
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].type" = "panel"
# IPUA for IPUs
register "device[1].name" = ""IPUA""
register "device[1].non_vga_device" = "true"
register "device[1].addr" = "0x3480"
device generic 0 on end
end
@ -229,13 +233,11 @@ chip soc/intel/jasperlake
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "ssdb.lanes_used" = "2"
register "ssdb.link_used" = "1"
register "ssdb.link_used" = "2"
register "ssdb.platform" = "PLAT_JSL"
register "ssdb.vcm_type" = "VCM_DW9714"
register "vcm_address" = "0x0C"
register "vcm_name" = ""VCM0""
register "ssdb.rom_type" = "ROM_EEPROM_CAT24C08"
register "rom_address" = "0x50"
register "num_freq_entries" = "1"
register "link_freq[0]" = "DEFAULT_LINK_FREQ"
register "remote_name" = ""IPU0""

13
src/mainboard/google/dedede/variants/magolor/overridetree.cb
View file

@ -128,11 +128,15 @@ chip soc/intel/jasperlake
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "1"
register "device_count" = "2"
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].type" = "panel"
# IPUA for IPUs
register "device[1].name" = ""IPUA""
register "device[1].non_vga_device" = "true"
register "device[1].addr" = "0x3480"
device generic 0 on end
end
@ -363,7 +367,7 @@ chip soc/intel/jasperlake
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "ssdb.lanes_used" = "2"
register "ssdb.link_used" = "1"
register "ssdb.link_used" = "2"
register "ssdb.platform" = "PLAT_JSL"
register "ssdb.vcm_type" = "VCM_DW9714"
register "vcm_address" = "0x0C"
@ -406,16 +410,15 @@ chip soc/intel/jasperlake
register "acpi_uid" = "0"
register "acpi_name" = ""CAM0""
register "chip_name" = ""Ov 8856 Camera""
register "sensor_name" = ""CJAJ813""
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "ssdb.lanes_used" = "2"
register "ssdb.link_used" = "1"
register "ssdb.link_used" = "2"
register "ssdb.platform" = "PLAT_JSL"
register "ssdb.vcm_type" = "VCM_DW9714"
register "vcm_address" = "0x0C"
register "vcm_name" = ""VCM0""
register "ssdb.rom_type" = "ROM_EEPROM_CAT24C08"
register "rom_address" = "0x50"
register "num_freq_entries" = "2"
register "link_freq[0]" = "720000000"
register "link_freq[1]" = "360000000"

10
src/mainboard/google/dedede/variants/storo/overridetree.cb
View file

@ -102,11 +102,15 @@ chip soc/intel/jasperlake
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "1"
register "device_count" = "2"
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].type" = "panel"
# IPUA for IPUs
register "device[1].name" = ""IPUA""
register "device[1].non_vga_device" = "true"
register "device[1].addr" = "0x3480"
device generic 0 on end
end
@ -237,13 +241,11 @@ chip soc/intel/jasperlake
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "ssdb.lanes_used" = "4"
register "ssdb.link_used" = "1"
register "ssdb.link_used" = "2"
register "ssdb.platform" = "PLAT_JSL"
register "ssdb.vcm_type" = "VCM_DW9714"
register "vcm_address" = "0x0C"
register "vcm_name" = ""VCM0""
register "ssdb.rom_type" = "ROM_EEPROM_CAT24C08"
register "rom_address" = "0x50"
register "num_freq_entries" = "2"
register "link_freq[0]" = "360000000"
register "link_freq[1]" = "180000000"

11
src/mainboard/google/dedede/variants/waddledoo/overridetree.cb
View file

@ -59,11 +59,15 @@ chip soc/intel/jasperlake
device domain 0 on
device ref igpu on
chip drivers/gfx/generic
register "device_count" = "1"
register "device_count" = "2"
# DDIA for eDP
register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].type" = "panel"
# IPUA for IPUs
register "device[1].name" = ""IPUA""
register "device[1].non_vga_device" = "true"
register "device[1].addr" = "0x3480"
device generic 0 on end
end
@ -162,6 +166,7 @@ chip soc/intel/jasperlake
register "acpi_name" = ""CAM1""
register "chip_name" = ""Ov 8856 Camera""
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "sensor_name" = ""CJAJ813""
register "ssdb.lanes_used" = "4"
register "ssdb.link_used" = "2"
@ -169,9 +174,6 @@ chip soc/intel/jasperlake
register "ssdb.vcm_type" = "VCM_DW9808"
register "vcm_address" = "0x0C"
register "vcm_name" = ""VCM0""
# placeholder; ROM type 24C1024 currently unsupported
# register "ssdb.rom_type" = "ROM_EEPROM_24C1024"
# register "rom_address" = "0x50"
register "num_freq_entries" = "2"
register "link_freq[0]" = "360000000"
register "link_freq[1]" = "180000000"
@ -236,6 +238,7 @@ chip soc/intel/jasperlake
register "acpi_name" = ""CAM0""
register "chip_name" = ""Ov 9734 Camera""
register "device_type" = "INTEL_ACPI_CAMERA_SENSOR"
register "sensor_name" = ""CJAJ813""
register "has_power_resource" = "true"
register "ssdb.lanes_used" = "1"