mb/google/dedede: Use DRIVERS_GFX_GENERIC for laptops

For dedede laptops, switch from using GMA_DEFAULT_PANEL(0), previously
set in the baseboard, to using a per-variant gfx generic chip driver,
so that variants which use IPU/MIPI cameras can add the IPUA camera
device in a subsequent commit.

For dedede laptops, this is a no-op; for Chromeboxes, it removes the
previously defined internal panel which they do not have.

TEST=build/boot dexi, magolor variants. verify ACPI brightness controls
still functional under Linux and Windows for the latter.

Change-Id: I83fd2d952ca785bef8210024cbbb9280688d6a5e
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/91065
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>

src/mainboard/google/dedede/Kconfig

@@ -278,6 +278,7 @@ if BOARD_GOOGLE_BASEBOARD_DEDEDE
 
 config BASEBOARD_DEDEDE_LAPTOP
 	def_bool n
+	select DRIVERS_GFX_GENERIC
 	select SYSTEM_TYPE_LAPTOP
 
 config CHROMEOS

src/mainboard/google/dedede/variants/awasuki/overridetree.cb

@@ -84,6 +84,17 @@ chip soc/intel/jasperlake
 	register "SdCardPowerEnableActiveHigh" = "0"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				## sensor information

src/mainboard/google/dedede/variants/baseboard/devicetree.cb

@@ -228,9 +228,7 @@ chip soc/intel/jasperlake
 	register "xhci_lfps_sampling_offtime_ms" = "9"
 
 	device domain 0 on
-		device ref igpu on
-			register "gfx" = "GMA_DEFAULT_PANEL(0)"
-		end
+		device ref igpu on end
 		device ref dptf on
 			# Default DPTF Policy for all Dedede boards if not overridden
 			chip drivers/intel/dptf

src/mainboard/google/dedede/variants/beadrix/overridetree.cb

@@ -60,6 +60,17 @@ chip soc/intel/jasperlake
 	register "SerialIoI2cMode[PchSerialIoIndexI2C5]" = "PchSerialIoPci"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			# Default DPTF Policy for all Dedede boards if not overridden
 			chip drivers/intel/dptf

src/mainboard/google/dedede/variants/blipper/overridetree.cb

@@ -63,6 +63,17 @@ chip soc/intel/jasperlake
 	register "FastPkgCRampDisable" = "1"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				## Passive Policy

src/mainboard/google/dedede/variants/boten/overridetree.cb

@@ -89,6 +89,17 @@ chip soc/intel/jasperlake
 	register "xhci_lfps_sampling_offtime_ms" = "0"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				## Passive Policy

src/mainboard/google/dedede/variants/bugzzy/overridetree.cb

@@ -94,6 +94,17 @@ chip soc/intel/jasperlake
 	register "SerialIoI2cMode[PchSerialIoIndexI2C4]" = "PchSerialIoPci"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				register "options.tsr[0].desc" = ""Memory""

src/mainboard/google/dedede/variants/cappy2/overridetree.cb

@@ -77,6 +77,17 @@ chip soc/intel/jasperlake
 	}" # Camera
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				## Passive Policy

src/mainboard/google/dedede/variants/corori/overridetree.cb

@@ -44,6 +44,17 @@ chip soc/intel/jasperlake
 	register "SerialIoGSpiCsMode[PchSerialIoIndexGSPI0]" = "0"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				## Passive Policy

src/mainboard/google/dedede/variants/cret/overridetree.cb

@@ -52,6 +52,17 @@ chip soc/intel/jasperlake
 		},
 	}"
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				## Passive Policy

src/mainboard/google/dedede/variants/drawcia/overridetree.cb

@@ -82,6 +82,17 @@ chip soc/intel/jasperlake
 	register "FastPkgCRampDisable" = "1"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref ipu on
 			chip drivers/intel/mipi_camera
 				register "acpi_uid" = "0x50000"

src/mainboard/google/dedede/variants/driblee/overridetree.cb

@@ -35,6 +35,17 @@ chip soc/intel/jasperlake
 	register "SerialIoGSpiCsMode[PchSerialIoIndexGSPI0]" = "0"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				## Passive Policy

src/mainboard/google/dedede/variants/galtic/overridetree.cb

@@ -69,6 +69,17 @@ chip soc/intel/jasperlake
 	register "tcc_offset" = "8"     # TCC of 97C
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			# Default DPTF Policy for all Dedede boards if not overridden
 			chip drivers/intel/dptf

src/mainboard/google/dedede/variants/gooey/overridetree.cb

@@ -68,6 +68,17 @@ chip soc/intel/jasperlake
 	register "xhci_lfps_sampling_offtime_ms" = "0"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				## Passive Policy

src/mainboard/google/dedede/variants/haboki/overridetree.cb

@@ -53,6 +53,17 @@ chip soc/intel/jasperlake
 	register "FastPkgCRampDisable" = "1"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref ipu on
 			chip drivers/intel/mipi_camera
 				register "acpi_uid" = "0x50000"

src/mainboard/google/dedede/variants/kracko/overridetree.cb

@@ -65,6 +65,17 @@ chip soc/intel/jasperlake
 	register "tcc_offset" = "20"	# TCC of 85C
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				# Default DPTF Policy for all drawcia boards if not overridden

src/mainboard/google/dedede/variants/lalala/overridetree.cb

@@ -87,6 +87,17 @@ chip soc/intel/jasperlake
 	register "FastPkgCRampDisable" = "1"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				register "options.tsr[0].desc" = ""Memory""

src/mainboard/google/dedede/variants/lantis/overridetree.cb

@@ -90,6 +90,17 @@ chip soc/intel/jasperlake
 	register "FastPkgCRampDisable" = "1"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				register "options.tsr[0].desc" = ""Memory""

src/mainboard/google/dedede/variants/madoo/overridetree.cb

@@ -57,6 +57,17 @@ chip soc/intel/jasperlake
 	register "SlowSlewRate" = "2"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				register "policies.passive" = "{

src/mainboard/google/dedede/variants/magolor/overridetree.cb

@@ -126,6 +126,17 @@ chip soc/intel/jasperlake
 	register "FastPkgCRampDisable" = "1"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				register "options.tsr[0].desc" = ""Memory""

src/mainboard/google/dedede/variants/metaknight/overridetree.cb

@@ -84,6 +84,17 @@ chip soc/intel/jasperlake
 	}"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				register "options.tsr[0].desc" = ""Memory""

src/mainboard/google/dedede/variants/pirika/overridetree.cb

@@ -78,6 +78,17 @@ chip soc/intel/jasperlake
 	register "tcc_offset" = "8"     # TCC of 97C
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			# Default DPTF Policy for all Dedede boards if not overridden
 			chip drivers/intel/dptf

src/mainboard/google/dedede/variants/sasuke/overridetree.cb

@@ -85,6 +85,17 @@ chip soc/intel/jasperlake
 	register "SerialIoI2cMode[PchSerialIoIndexI2C4]" = "PchSerialIoPci"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				register "options.tsr[0].desc" = ""Charger""

src/mainboard/google/dedede/variants/sasukette/overridetree.cb

@@ -96,6 +96,17 @@ chip soc/intel/jasperlake
 	register "xhci_lfps_sampling_offtime_ms" = "0"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				## Passive Policy

src/mainboard/google/dedede/variants/storo/overridetree.cb

@@ -100,6 +100,17 @@ chip soc/intel/jasperlake
 	register "xhci_lfps_sampling_offtime_ms" = "0"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref dptf on
 			chip drivers/intel/dptf
 				## Passive Policy

src/mainboard/google/dedede/variants/waddledee/overridetree.cb

@@ -61,6 +61,17 @@ chip soc/intel/jasperlake
 	register "SerialIoI2cMode[PchSerialIoIndexI2C4]" = "PchSerialIoPci"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref ipu on end
 		device ref south_xhci on
 			chip drivers/usb/acpi

src/mainboard/google/dedede/variants/waddledoo/overridetree.cb

@@ -57,6 +57,17 @@ chip soc/intel/jasperlake
 	register "SerialIoI2cMode[PchSerialIoIndexI2C4]" = "PchSerialIoPci"
 
 	device domain 0 on
+		device ref igpu on
+			chip drivers/gfx/generic
+				register "device_count" = "1"
+				# DDIA for eDP
+				register "device[0].name" = ""LCD0""
+				# Internal panel on the first port of the graphics chip
+				register "device[0].type" = "panel"
+
+				device generic 0 on end
+			end
+		end
 		device ref ipu on
 			chip drivers/intel/mipi_camera
 				register "acpi_uid" = "0x50000"