util/autoport: Fix newly-added Kconfig select
Commit4a09db75d9("util/autoport: Add support for 9 Series PCHs (Lynx Point Refresh)") got submitted after commit01d82febb2("util/autoport: Separate handling of Kconfig selects"). The latter commit was specifically made so that the former commit could properly express a Kconfig select with a condition. However, the former commit did not get updated, and got submitted as-is since there was no unresolved review comment to keep track of this TODO. As a result, what should have been a conditional Kconfig select but with the condition in a comment to work around limitations of the original system accidentally became a bool option override. So, simply use the new system to express a conditional Kconfig select. This fixes the wrongly-generated Kconfig as well as the original issue. Even though this would still have worked, the `USE_BROADWELL_MRC` option must be selected for boards with a Lynx Point Refresh PCH, since Haswell MRC will not work on those PCHs. Still, this can be caught and corrected during review, in case any board ports are made before this fix lands. Change-Id: I98f032283e9e5bb5ec13dbff382304b7abfec07e Signed-off-by: Angel Pons <th3fanbus@gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/91027 Reviewed-by: Nicholas <nic.c3.14@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
parent
1b7aa42421
commit
1f20a947c5
1 changed files with 1 additions and 2 deletions
|
|
@ -163,8 +163,7 @@ func (b lynxpoint) Scan(ctx Context, addr PCIDevData) {
|
|||
}
|
||||
|
||||
if (b.variant == LYNX_POINT_REFRESH) {
|
||||
KconfigBool["USE_BROADWELL_MRC"] = true
|
||||
KconfigComment["USE_BROADWELL_MRC"] = "if !USE_NATIVE_RAMINIT # FIXME: Uncomment the if"
|
||||
KconfigSelect["USE_BROADWELL_MRC"] = "!USE_NATIVE_RAMINIT"
|
||||
}
|
||||
|
||||
FADT := ctx.InfoSource.GetACPI()["FACP"]
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue