erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/var/uldrenite: Fix fw_config_gpio_padbased_override not being called

Browse source 
Found that certain pins did not change according to the fw_config
settings. After tracing the code, discovered that
fw_config_gpio_padbased_override() was not being called, so this change
fixes the issue.

BUG=b:410481989
TEST=emerge-nissa coreboot

Change-Id: I07fb7860b32bae4922783fe437baafdd1c86482e
Signed-off-by: John Su <john_su@compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87546
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com>
This commit is contained in:
John Su 2025-05-06 19:08:29 +08:00 • committed by Matt DeVillier
commit 18b4349422
1 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/mainboard/google/brya/variants/uldrenite/variant.c
View file

@ -8,6 +8,7 @@
#include <fw_config.h>
#include <sar.h>
#include <soc/bootblock.h>
#include <stdlib.h>
const char *get_wifi_sar_cbfs_filename(void)
{
@ -122,3 +123,17 @@ void variant_update_descriptor(void)
configure_descriptor(fivr_bytes, ARRAY_SIZE(fivr_bytes));
}
}
void variant_configure_pads(void)
{
const struct pad_config *base_pads;
struct pad_config *padbased_table;
size_t base_num;
padbased_table = new_padbased_table();
base_pads = variant_gpio_table(&base_num);
gpio_padbased_override(padbased_table, base_pads, base_num);
fw_config_gpio_padbased_override(padbased_table);
gpio_configure_pads_with_padbased(padbased_table);
free(padbased_table);
}