From 18b43494229bc1c31a6861e71d0a2a462dad1dfd Mon Sep 17 00:00:00 2001 From: John Su Date: Tue, 6 May 2025 19:08:29 +0800 Subject: [PATCH] mb/var/uldrenite: Fix fw_config_gpio_padbased_override not being called Found that certain pins did not change according to the fw_config settings. After tracing the code, discovered that fw_config_gpio_padbased_override() was not being called, so this change fixes the issue. BUG=b:410481989 TEST=emerge-nissa coreboot Change-Id: I07fb7860b32bae4922783fe437baafdd1c86482e Signed-off-by: John Su Reviewed-on: https://review.coreboot.org/c/coreboot/+/87546 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) Reviewed-by: Dtrain Hsu --- .../google/brya/variants/uldrenite/variant.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/mainboard/google/brya/variants/uldrenite/variant.c b/src/mainboard/google/brya/variants/uldrenite/variant.c index 532752837f..f5d01c1a89 100644 --- a/src/mainboard/google/brya/variants/uldrenite/variant.c +++ b/src/mainboard/google/brya/variants/uldrenite/variant.c @@ -8,6 +8,7 @@ #include #include #include +#include const char *get_wifi_sar_cbfs_filename(void) { @@ -122,3 +123,17 @@ void variant_update_descriptor(void) configure_descriptor(fivr_bytes, ARRAY_SIZE(fivr_bytes)); } } + +void variant_configure_pads(void) +{ + const struct pad_config *base_pads; + struct pad_config *padbased_table; + size_t base_num; + + padbased_table = new_padbased_table(); + base_pads = variant_gpio_table(&base_num); + gpio_padbased_override(padbased_table, base_pads, base_num); + fw_config_gpio_padbased_override(padbased_table); + gpio_configure_pads_with_padbased(padbased_table); + free(padbased_table); +}