erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/starlabs/starbook/mtl: Don't configure GPIOs to IOSTANDBY_IGNORE

Browse source 
This is just simply incorrect, as these signals are used to
pull various devices into low power states during S3.

Change-Id: Ic2950cc43fd17dda4205964c851b09cfd86d90d9
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87013
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Sean Rhodes 2025-03-26 21:09:13 +00:00 • committed by Matt DeVillier
commit 1467e5fbd3
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/mainboard/starlabs/starbook/variants/mtl/gpio.c
View file

@ -29,17 +29,17 @@ const struct pad_config gpio_table[] = {
* End: GPP_V22 * End: GPP_V22
*/ */
/* V00: PM_BATLOW_N */ /* V00: PM_BATLOW_N */
PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_V00, NONE, DEEP, NF1), PAD_CFG_NF(GPP_V00, NONE, DEEP, NF1),
/* V01: CHG_ACOK */ /* V01: CHG_ACOK */
PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_V01, NONE, DEEP, NF1), PAD_CFG_NF(GPP_V01, NONE, DEEP, NF1),
/* V02: PCIE_WAKE_LAN */ /* V02: PCIE_WAKE_LAN */
PAD_NC(GPP_V02, NONE), PAD_NC(GPP_V02, NONE),
/* V03: EC_PWRBTN_N */ /* V03: EC_PWRBTN_N */
PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_V03, UP_20K, DEEP, NF1), PAD_CFG_NF(GPP_V03, UP_20K, DEEP, NF1),
/* V04: PM_SLP_S3_N */ /* V04: PM_SLP_S3_N */
PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_V04, NONE, DEEP, NF1), PAD_CFG_NF(GPP_V04, NONE, DEEP, NF1),
/* V05: SLP S4# */ /* V05: SLP S4# */
PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_V05, NONE, DEEP, NF1), PAD_CFG_NF(GPP_V05, NONE, DEEP, NF1),
/* V06: GPD_6_SLP_A_N */ /* V06: GPD_6_SLP_A_N */
PAD_NC(GPP_V06, NONE), PAD_NC(GPP_V06, NONE),
/* V07: */ /* V07: */
@ -97,9 +97,9 @@ const struct pad_config gpio_table[] = {
* WEAK INTERNAL PD 20K */ * WEAK INTERNAL PD 20K */
PAD_CFG_GPO(GPP_C05, 0, PLTRST), PAD_CFG_GPO(GPP_C05, 0, PLTRST),
/* C06: SML1_CLK_USBC_PD_N */ /* C06: SML1_CLK_USBC_PD_N */
PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_C06, NONE, DEEP, NF1), PAD_CFG_NF(GPP_C06, NONE, DEEP, NF1),
/* C07: SML1_DATA_USBC_PD_N */ /* C07: SML1_DATA_USBC_PD_N */
PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_C07, NONE, DEEP, NF1), PAD_CFG_NF(GPP_C07, NONE, DEEP, NF1),
/* C08: SML1ALERT */ /* C08: SML1ALERT */
PAD_CFG_NF(GPP_C08, NONE, DEEP, NF1), PAD_CFG_NF(GPP_C08, NONE, DEEP, NF1),
/* C09: */ /* C09: */
@ -182,7 +182,7 @@ const struct pad_config gpio_table[] = {
/* A20: M.2_CPU_SSD_RESET_N */ /* A20: M.2_CPU_SSD_RESET_N */
PAD_CFG_GPO(GPP_A20, 1, PLTRST), PAD_CFG_GPO(GPP_A20, 1, PLTRST),
/* A21: I2C_PMC_PD_INT_N */ /* A21: I2C_PMC_PD_INT_N */
PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A21, NONE, DEEP, NF1), PAD_CFG_NF(GPP_A21, NONE, DEEP, NF1),
/* A22: */ /* A22: */
PAD_NC(GPP_A22, NONE), PAD_NC(GPP_A22, NONE),
/* A23: */ /* A23: */