From 1467e5fbd3160aae5a82e678e24b5785e76b6d25 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 26 Mar 2025 21:09:13 +0000 Subject: [PATCH] mb/starlabs/starbook/mtl: Don't configure GPIOs to IOSTANDBY_IGNORE This is just simply incorrect, as these signals are used to pull various devices into low power states during S3. Change-Id: Ic2950cc43fd17dda4205964c851b09cfd86d90d9 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/87013 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- .../starlabs/starbook/variants/mtl/gpio.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index 8619f24c25..d1b915ab9e 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -29,17 +29,17 @@ const struct pad_config gpio_table[] = { * End: GPP_V22 */ /* V00: PM_BATLOW_N */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_V00, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_V00, NONE, DEEP, NF1), /* V01: CHG_ACOK */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_V01, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_V01, NONE, DEEP, NF1), /* V02: PCIE_WAKE_LAN */ PAD_NC(GPP_V02, NONE), /* V03: EC_PWRBTN_N */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_V03, UP_20K, DEEP, NF1), + PAD_CFG_NF(GPP_V03, UP_20K, DEEP, NF1), /* V04: PM_SLP_S3_N */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_V04, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_V04, NONE, DEEP, NF1), /* V05: SLP S4# */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_V05, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_V05, NONE, DEEP, NF1), /* V06: GPD_6_SLP_A_N */ PAD_NC(GPP_V06, NONE), /* V07: */ @@ -97,9 +97,9 @@ const struct pad_config gpio_table[] = { * WEAK INTERNAL PD 20K */ PAD_CFG_GPO(GPP_C05, 0, PLTRST), /* C06: SML1_CLK_USBC_PD_N */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_C06, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_C06, NONE, DEEP, NF1), /* C07: SML1_DATA_USBC_PD_N */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_C07, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_C07, NONE, DEEP, NF1), /* C08: SML1ALERT */ PAD_CFG_NF(GPP_C08, NONE, DEEP, NF1), /* C09: */ @@ -182,7 +182,7 @@ const struct pad_config gpio_table[] = { /* A20: M.2_CPU_SSD_RESET_N */ PAD_CFG_GPO(GPP_A20, 1, PLTRST), /* A21: I2C_PMC_PD_INT_N */ - PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_A21, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_A21, NONE, DEEP, NF1), /* A22: */ PAD_NC(GPP_A22, NONE), /* A23: */