mb/starlabs/*: Set all I2C speeds to fast
The default i2c speed is I2C_SPEED_STANDARD, but the coreboot driver defaults to I2C_SPEED_FAST. The difference in performance and power consumption is negligible, so set the buses to fast and remove the superfluous option. Change-Id: Ic722e971e6f94965d28fd158a46d144a19490199 Signed-off-by: Sean Rhodes <sean@starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84736 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
parent
c018af5e5b
commit
02103cde7c
7 changed files with 39 additions and 6 deletions
|
|
@ -8,6 +8,12 @@ chip soc/intel/alderlake
|
|||
[PchSerialIoIndexI2C0] = PchSerialIoPci,
|
||||
}"
|
||||
|
||||
register "common_soc_config" = "{
|
||||
.i2c[0] = {
|
||||
.speed = I2C_SPEED_FAST,
|
||||
},
|
||||
}"
|
||||
|
||||
register "serial_io_uart_mode" = "{
|
||||
[PchSerialIoIndexUART0] = PchSerialIoSkipInit,
|
||||
}"
|
||||
|
|
|
|||
|
|
@ -21,6 +21,12 @@ chip soc/intel/cannonlake
|
|||
[PchSerialIoIndexUART2] = PchSerialIoSkipInit,
|
||||
}"
|
||||
|
||||
register "common_soc_config" = "{
|
||||
.i2c[0] = {
|
||||
.speed = I2C_SPEED_FAST,
|
||||
},
|
||||
}"
|
||||
|
||||
# Power
|
||||
register "PchPmSlpS3MinAssert" = "2" # 50ms
|
||||
register "PchPmSlpS4MinAssert" = "3" # 1s
|
||||
|
|
|
|||
|
|
@ -20,6 +20,12 @@ chip soc/intel/skylake
|
|||
[PchSerialIoIndexUart2] = PchSerialIoSkipInit,
|
||||
}"
|
||||
|
||||
register "common_soc_config" = "{
|
||||
.i2c[0] = {
|
||||
.speed = I2C_SPEED_FAST,
|
||||
},
|
||||
}"
|
||||
|
||||
# Power
|
||||
register "PmConfigSlpS3MinAssert" = "2" # 50ms
|
||||
register "PmConfigSlpS4MinAssert" = "3" # 1s
|
||||
|
|
|
|||
|
|
@ -10,6 +10,12 @@ chip soc/intel/alderlake
|
|||
[PchSerialIoIndexI2C0] = PchSerialIoPci,
|
||||
}"
|
||||
|
||||
register "common_soc_config" = "{
|
||||
.i2c[0] = {
|
||||
.speed = I2C_SPEED_FAST,
|
||||
},
|
||||
}"
|
||||
|
||||
register "serial_io_uart_mode" = "{
|
||||
[PchSerialIoIndexUART0] = PchSerialIoSkipInit,
|
||||
}"
|
||||
|
|
|
|||
|
|
@ -22,6 +22,12 @@ chip soc/intel/tigerlake
|
|||
[PchSerialIoIndexI2C4] = PchSerialIoSkipInit,
|
||||
}"
|
||||
|
||||
register "common_soc_config" = "{
|
||||
.i2c[0] = {
|
||||
.speed = I2C_SPEED_FAST,
|
||||
},
|
||||
}"
|
||||
|
||||
register "SerialIoUartMode" = "{
|
||||
[PchSerialIoIndexUART2] = PchSerialIoSkipInit,
|
||||
}"
|
||||
|
|
|
|||
|
|
@ -11,6 +11,15 @@ chip soc/intel/alderlake
|
|||
[PchSerialIoIndexI2C2] = PchSerialIoPci,
|
||||
}"
|
||||
|
||||
register "common_soc_config" = "{
|
||||
.i2c[0] = {
|
||||
.speed = I2C_SPEED_FAST,
|
||||
},
|
||||
.i2c[2] = {
|
||||
.speed = I2C_SPEED_FAST,
|
||||
}
|
||||
}"
|
||||
|
||||
register "serial_io_uart_mode" = "{
|
||||
[PchSerialIoIndexUART0] = PchSerialIoSkipInit,
|
||||
}"
|
||||
|
|
|
|||
|
|
@ -68,10 +68,4 @@ void devtree_update(void)
|
|||
/* Enable/Disable Accelerometer based on CMOS settings */
|
||||
if (get_uint_option("accelerometer", 1) == 0)
|
||||
accelerometer_dev->enabled = 0;
|
||||
|
||||
/* Set I2C devices speed to fast based on CMOS settings */
|
||||
if (get_uint_option("i2c_speed_fast", 0) == 1) {
|
||||
common_config->i2c[0].speed = I2C_SPEED_FAST;
|
||||
common_config->i2c[2].speed = I2C_SPEED_FAST;
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue