From 02103cde7ce8ce32f407ab69ec26cf8d79309869 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Fri, 11 Oct 2024 12:25:16 +0100 Subject: [PATCH] mb/starlabs/*: Set all I2C speeds to fast The default i2c speed is I2C_SPEED_STANDARD, but the coreboot driver defaults to I2C_SPEED_FAST. The difference in performance and power consumption is negligible, so set the buses to fast and remove the superfluous option. Change-Id: Ic722e971e6f94965d28fd158a46d144a19490199 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/84736 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- .../starlabs/starbook/variants/adl/devicetree.cb | 6 ++++++ .../starlabs/starbook/variants/cml/devicetree.cb | 6 ++++++ .../starlabs/starbook/variants/kbl/devicetree.cb | 6 ++++++ .../starlabs/starbook/variants/rpl/devicetree.cb | 6 ++++++ .../starlabs/starbook/variants/tgl/devicetree.cb | 6 ++++++ .../starlabs/starlite_adl/variants/mk_v/devicetree.cb | 9 +++++++++ .../starlabs/starlite_adl/variants/mk_v/devtree.c | 6 ------ 7 files changed, 39 insertions(+), 6 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 8b4daf6efe..ce5bda4b5d 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -8,6 +8,12 @@ chip soc/intel/alderlake [PchSerialIoIndexI2C0] = PchSerialIoPci, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + }" + register "serial_io_uart_mode" = "{ [PchSerialIoIndexUART0] = PchSerialIoSkipInit, }" diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb index db646e3e6a..6769ac9b9b 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb @@ -21,6 +21,12 @@ chip soc/intel/cannonlake [PchSerialIoIndexUART2] = PchSerialIoSkipInit, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + }" + # Power register "PchPmSlpS3MinAssert" = "2" # 50ms register "PchPmSlpS4MinAssert" = "3" # 1s diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb index 21c475e628..a594f7a1f7 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb @@ -20,6 +20,12 @@ chip soc/intel/skylake [PchSerialIoIndexUart2] = PchSerialIoSkipInit, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + }" + # Power register "PmConfigSlpS3MinAssert" = "2" # 50ms register "PmConfigSlpS4MinAssert" = "3" # 1s diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index 8889cf6f25..7faf157cc6 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -10,6 +10,12 @@ chip soc/intel/alderlake [PchSerialIoIndexI2C0] = PchSerialIoPci, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + }" + register "serial_io_uart_mode" = "{ [PchSerialIoIndexUART0] = PchSerialIoSkipInit, }" diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb index 9f208b9aa0..c2212851e7 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb @@ -22,6 +22,12 @@ chip soc/intel/tigerlake [PchSerialIoIndexI2C4] = PchSerialIoSkipInit, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + }" + register "SerialIoUartMode" = "{ [PchSerialIoIndexUART2] = PchSerialIoSkipInit, }" diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index 3d49cc174e..e1cb6bdf81 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -11,6 +11,15 @@ chip soc/intel/alderlake [PchSerialIoIndexI2C2] = PchSerialIoPci, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + } + }" + register "serial_io_uart_mode" = "{ [PchSerialIoIndexUART0] = PchSerialIoSkipInit, }" diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c index 8c35c5ce24..6067a46929 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c @@ -68,10 +68,4 @@ void devtree_update(void) /* Enable/Disable Accelerometer based on CMOS settings */ if (get_uint_option("accelerometer", 1) == 0) accelerometer_dev->enabled = 0; - - /* Set I2C devices speed to fast based on CMOS settings */ - if (get_uint_option("i2c_speed_fast", 0) == 1) { - common_config->i2c[0].speed = I2C_SPEED_FAST; - common_config->i2c[2].speed = I2C_SPEED_FAST; - } }