Remove embedTweet.js, use <base target="_blank"> instead

This commit is contained in:
Zed 2026-08-10 20:27:38 +07:00
commit ca19250a62
2 changed files with 5 additions and 34 deletions

View file

@ -1,28 +0,0 @@
// This runs after embedResize.js sets up the sendHeight function
(function() {
var sendHeight = window._nitterSendHeight;
// Make images load eagerly so height updates correctly
var lazyImages = document.querySelectorAll('img[loading="lazy"]');
for (var i = 0; i < lazyImages.length; i++) {
lazyImages[i].loading = 'eager';
}
// Update height when images finish loading (only if sendHeight available)
if (sendHeight) {
var allImages = document.querySelectorAll('img');
for (var i = 0; i < allImages.length; i++) {
var img = allImages[i];
if (!img.complete) {
img.addEventListener('load', sendHeight);
}
}
}
// Open all links in new tab (we're in an iframe)
var allLinks = document.querySelectorAll('a');
for (var i = 0; i < allLinks.length; i++) {
allLinks[i].target = '_blank';
}
})();

View file

@ -8,8 +8,6 @@ import general, tweet
const const
doctype = "<!DOCTYPE html>\n" doctype = "<!DOCTYPE html>\n"
embedResizeJs = staticRead("../../public/js/embedResize.js") embedResizeJs = staticRead("../../public/js/embedResize.js")
embedTweetJs = embedResizeJs & ";" & staticRead("../../public/js/embedTweet.js")
embedErrorJs = embedResizeJs & ";if(window._nitterSendHeight)requestAnimationFrame(window._nitterSendHeight);"
proc renderVideoEmbed*(tweet: Tweet; cfg: Config; req: Request): string = proc renderVideoEmbed*(tweet: Tweet; cfg: Config; req: Request): string =
let let
@ -33,17 +31,18 @@ proc renderVideoEmbed*(tweet: Tweet; cfg: Config; req: Request): string =
proc renderTweetEmbed*(tweet: Tweet; path: string; prefs: Prefs; cfg: Config; req: Request): string = proc renderTweetEmbed*(tweet: Tweet; path: string; prefs: Prefs; cfg: Config; req: Request): string =
let node = buildHtml(html(lang="en")): let node = buildHtml(html(lang="en")):
renderHead(prefs, cfg, req) renderHead(prefs, cfg, req)
base(target="_blank")
body: body:
tdiv(class="embed-wrapper"): tdiv(class="embed-wrapper"):
tdiv(class="tweet-embed"): tdiv(class="tweet-embed"):
a(class="tweet-link", href=getLink(tweet), target="_blank") a(class="tweet-link", href=getLink(tweet))
renderTweet(tweet, prefs, path, mainTweet=true) renderTweet(tweet, prefs, path, mainTweet=true)
a(class="embed-footer", href=getLink(tweet), target="_blank"): a(class="embed-footer", href=getLink(tweet)):
text "Read more on " & cfg.hostname text "Read more on " & cfg.hostname
script: script:
verbatim embedTweetJs verbatim embedResizeJs
result = doctype & $node result = doctype & $node
@ -57,6 +56,6 @@ proc renderErrorEmbed*(error: string; prefs: Prefs; cfg: Config; req: Request):
span: text error span: text error
script: script:
verbatim embedErrorJs verbatim embedResizeJs
result = doctype & $node result = doctype & $node