[WIP/ADD] Try to separate discovery, make links nicer

configure.c

@@ -90,22 +90,6 @@ string_cat(char *in1, char *in2)
 
     return out;
 }
-static char *
-trim_nl(char *in)
-{
-    char *tc;
-    if (!in)
-    {
-        return NULL;
-    }
-
-    while ((tc = strrchr(in, '\n')))
-    {
-        *tc = '\0';
-    }
-
-    return in;
-}
 
 typedef struct str_array {
     char **values;
@@ -115,6 +99,10 @@ static str_array_t *
 str_array_create(void)
 {
     str_array_t *ret = malloc(sizeof(*ret));
+    if (!ret)
+    {
+        return NULL;
+    }
 
     ret->values = NULL;
     ret->quantity = 0;
@@ -216,36 +204,6 @@ failure:
     free(line);
     return NULL;
 }
-static int
-exec_code(char *program, char *argv[])
-{
-    pid_t forkRet;
-    if (!program || !argv)
-    {
-        return -1;
-    }
-
-    forkRet = fork();
-    if (forkRet == 0)
-    {
-        /* Child */
-        execvp(program, argv);
-        exit(0);
-    }
-    else
-    {
-        /* Parent */
-        int status;
-        if (waitpid(forkRet, &status, 0) == -1)
-        {
-            return -1;
-        }
-        return status;
-    }
-
-    /* We're not meant to ever be there, but TCC is stupid. */
-    return -1;
-}
 
 static char *
 strchrn(char *s, char c)
@@ -253,17 +211,6 @@ strchrn(char *s, char c)
     s = strchr(s, c);
     return s ? s+1 : NULL;
 }
-static char *
-strchrl(char *s, char c)
-{
-    char *s1 = NULL;
-    while ((s = strchr(s, c)))
-    {
-        s1 = s;
-        s++;
-    }
-    return s1;
-}
 static str_array_t *
 split(char *dir)
 {
@@ -512,8 +459,7 @@ main_build(int argc, char *argv[])
 {
     FILE *makefile;
     char *repo = cmd_stdout("git remote get-url origin");
-    size_t size, i;
-    ssize_t nread;
+    size_t i;
     bool with_static = false, with_lmdb = false;
     int opt;
     str_array_t *sources, *images, *utils, *aya;
@@ -546,6 +492,13 @@ main_build(int argc, char *argv[])
     }
 
     makefile = fopen("Makefile", "w");
+    if (!makefile)
+    {
+        fprintf(stderr, "Couldn't create Makefile.\n");
+        fprintf(stderr, "This isn't good, actually.\n");
+
+        return EXIT_FAILURE;
+    }
     fprintf(makefile, "# Autogenerated POSIX Makefile from Parsee\n");
     fprintf(makefile, "# Ideally do not touch, unless you have a very ");
     fprintf(makefile, "good reason to do it. \n\n");