Python 3 port:

/!\ this is a huge commit
/!\ starting from this commit, SàT is needs Python 3.6+
/!\ SàT maybe be instable or some feature may not work anymore, this will improve with time

This patch port backend, bridge and frontends to Python 3.

Roughly this has been done this way:

- 2to3 tools has been applied (with python 3.7)
- all references to python2 have been replaced with python3 (notably shebangs)
- fixed files not handled by 2to3 (notably the shell script)
- several manual fixes
- fixed issues reported by Python 3 that where not handled in Python 2
- replaced "async" with "async_" when needed (it's a reserved word from Python 3.7)
- replaced zope's "implements" with @implementer decorator
- temporary hack to handle data pickled in database, as str or bytes may be returned,
  to be checked later
- fixed hash comparison for password
- removed some code which is not needed anymore with Python 3
- deactivated some code which needs to be checked (notably certificate validation)
- tested with jp, fixed reported issues until some basic commands worked
- ported Primitivus (after porting dependencies like urwid satext)
- more manual fixes

sat/plugins/plugin_misc_upload.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # -*- coding: utf-8 -*-
 
 # SAT plugin for file tansfer
@@ -41,8 +41,8 @@ PLUGIN_INFO = {
 }
 
 
-UPLOADING = D_(u"Please select a file to upload")
-UPLOADING_TITLE = D_(u"File upload")
+UPLOADING = D_("Please select a file to upload")
+UPLOADING_TITLE = D_("File upload")
 BOOL_OPTIONS = ("ignore_tls_errors",)
 
 
@@ -58,7 +58,7 @@ class UploadPlugin(object):
             in_sign="sssa{ss}s",
             out_sign="a{ss}",
             method=self._fileUpload,
-            async=True,
+            async_=True,
         )
         self._upload_callbacks = []
 
@@ -97,12 +97,12 @@ class UploadPlugin(object):
                 and fail.value.condition == 'not-acceptable'):
                 reason = fail.value.text
             else:
-                reason = unicode(fail.value)
-            msg = D_(u"Can't upload file: {reason}").format(reason=reason)
+                reason = str(fail.value)
+            msg = D_("Can't upload file: {reason}").format(reason=reason)
             log.warning(msg)
             return {
                 "xmlui": xml_tools.note(
-                    msg, D_(u"Can't upload file"), C.XMLUI_DATA_LVL_WARNING
+                    msg, D_("Can't upload file"), C.XMLUI_DATA_LVL_WARNING
                 ).toXml()
             }
 
@@ -130,7 +130,7 @@ class UploadPlugin(object):
         if options is None:
             options = {}
         if not os.path.isfile(filepath):
-            raise exceptions.DataError(u"The given path doesn't link to a file")
+            raise exceptions.DataError("The given path doesn't link to a file")
         for method_name, available_cb, upload_cb, priority in self._upload_callbacks:
             try:
                 upload_jid = yield available_cb(upload_jid, client.profile)
@@ -138,7 +138,7 @@ class UploadPlugin(object):
                 continue  # no entity managing this extension found
 
             log.info(
-                u"{name} method will be used to upload the file".format(name=method_name)
+                "{name} method will be used to upload the file".format(name=method_name)
             )
             progress_id_d, download_d = yield upload_cb(
                 filepath, filename, upload_jid, options, client.profile
@@ -146,7 +146,7 @@ class UploadPlugin(object):
             progress_id = yield progress_id_d
             defer.returnValue((progress_id, download_d))
 
-        raise exceptions.NotFound(u"Can't find any method to upload a file")
+        raise exceptions.NotFound("Can't find any method to upload a file")
 
     def register(self, method_name, available_cb, upload_cb, priority=0):
         """Register a fileUploading method
@@ -167,7 +167,7 @@ class UploadPlugin(object):
         for data in self._upload_callbacks:
             if method_name == data[0]:
                 raise exceptions.ConflictError(
-                    u"A method with this name is already registered"
+                    "A method with this name is already registered"
                 )
         self._upload_callbacks.append((method_name, available_cb, upload_cb, priority))
         self._upload_callbacks.sort(key=lambda data: data[3], reverse=True)
@@ -177,4 +177,4 @@ class UploadPlugin(object):
             if data[0] == method_name:
                 del [idx]
                 return
-        raise exceptions.NotFound(u"The name to unregister doesn't exist")
+        raise exceptions.NotFound("The name to unregister doesn't exist")