From ed0312261efe3b7989617bbf7455eed841b4b840 Mon Sep 17 00:00:00 2001
From: Goffi <goffi@goffi.org>
Date: Fri, 4 Jan 2019 18:44:43 +0100
Subject: [PATCH] core (xmpp): don't add to history a message if there is no
 message and no subject.

---
 sat/core/xmpp.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sat/core/xmpp.py b/sat/core/xmpp.py
index c8a7fd4a..c8b6b6aa 100644
--- a/sat/core/xmpp.py
+++ b/sat/core/xmpp.py
@@ -970,7 +970,11 @@ class SatMessageProtocol(xmppim.MessageProtocol):
             log.info(u"history is skipped as requested")
             data[u"extra"][u"history"] = C.HISTORY_SKIP
         else:
-            return self.host.memory.addToHistory(self.parent, data)
+            if data[u"message"] or data[u"subject"]:  # we need a message to store
+                return self.host.memory.addToHistory(self.parent, data)
+            else:
+                log.debug(u"not storing empty message to history: {data}"
+                    .format(data=data))
 
     def bridgeSignal(self, __, data):
         try: