From e393c908b0fb4a1fd1ad11fee3fe2369961566ee Mon Sep 17 00:00:00 2001 From: Goffi Date: Mon, 31 Jan 2022 18:35:52 +0100 Subject: [PATCH] tools (xml_tools): fix `widget_args` modification in `_dataFormField2XMLUIData`: in `textbox` widget, the first arg was modified with all values, lettings other ones unchanger, resulting in invalid number of arguments. This has been fixed by replacing all args with the new value. --- sat/tools/xml_tools.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sat/tools/xml_tools.py b/sat/tools/xml_tools.py index 1976bd62..69db3f5f 100644 --- a/sat/tools/xml_tools.py +++ b/sat/tools/xml_tools.py @@ -89,7 +89,7 @@ def _dataFormField2XMLUIData(field, read_only=False): else: field.value = field.label field.label = None - widget_args[0] = field.value + widget_args = [field.value] elif field.fieldType == "text-single": widget_type = "string" widget_kwargs["read_only"] = read_only @@ -98,7 +98,7 @@ def _dataFormField2XMLUIData(field, read_only=False): widget_kwargs["read_only"] = read_only elif field.fieldType == "text-multi": widget_type = "textbox" - widget_args[0] = "\n".join(field.values) + widget_args = ["\n".join(field.values)] widget_kwargs["read_only"] = read_only elif field.fieldType == "hidden": widget_type = "hidden" @@ -108,7 +108,7 @@ def _dataFormField2XMLUIData(field, read_only=False): elif field.fieldType == "boolean": widget_type = "bool" if widget_args[0] is None: - widget_args[0] = "false" + widget_args = ["false"] widget_kwargs["read_only"] = read_only elif field.fieldType == "integer": widget_type = "integer"