plugin pubsub cache: avoid race condition by retrying node request:
When retrieving items, there may be a race condition if a node is not found in cache, then created before `setPubsubNode` is called. This patch handle this case by retrying in case of UNIQUE constraint violation.
This commit is contained in:
parent
8097e04747
commit
dbbdcd04bb
1 changed files with 31 additions and 16 deletions
|
|
@ -30,7 +30,7 @@ from sat.core.log import getLogger
|
||||||
from sat.core.core_types import SatXMPPEntity
|
from sat.core.core_types import SatXMPPEntity
|
||||||
from sat.tools import xml_tools, utils
|
from sat.tools import xml_tools, utils
|
||||||
from sat.tools.common import data_format
|
from sat.tools.common import data_format
|
||||||
from sat.memory.sqla import PubsubNode, PubsubItem, SyncState
|
from sat.memory.sqla import PubsubNode, PubsubItem, SyncState, IntegrityError
|
||||||
|
|
||||||
|
|
||||||
log = getLogger(__name__)
|
log = getLogger(__name__)
|
||||||
|
|
@ -612,22 +612,37 @@ class PubsubCache:
|
||||||
return True, None
|
return True, None
|
||||||
if service is None:
|
if service is None:
|
||||||
service = client.jid.userhostJID()
|
service = client.jid.userhostJID()
|
||||||
pubsub_node = await self.host.memory.storage.getPubsubNode(
|
for __ in range(5):
|
||||||
client, service, node
|
pubsub_node = await self.host.memory.storage.getPubsubNode(
|
||||||
)
|
client, service, node
|
||||||
if pubsub_node is not None and pubsub_node.sync_state == SyncState.COMPLETED:
|
)
|
||||||
analyse = {"to_sync": True}
|
if pubsub_node is not None and pubsub_node.sync_state == SyncState.COMPLETED:
|
||||||
else:
|
analyse = {"to_sync": True}
|
||||||
analyse = await self.analyseNode(client, service, node)
|
else:
|
||||||
|
analyse = await self.analyseNode(client, service, node)
|
||||||
|
|
||||||
if pubsub_node is None:
|
if pubsub_node is None:
|
||||||
pubsub_node = await self.host.memory.storage.setPubsubNode(
|
try:
|
||||||
client,
|
pubsub_node = await self.host.memory.storage.setPubsubNode(
|
||||||
service,
|
client,
|
||||||
node,
|
service,
|
||||||
analyser=analyse.get("name"),
|
node,
|
||||||
type_=analyse.get("type"),
|
analyser=analyse.get("name"),
|
||||||
subtype=analyse.get("subtype"),
|
type_=analyse.get("type"),
|
||||||
|
subtype=analyse.get("subtype"),
|
||||||
|
)
|
||||||
|
except IntegrityError as e:
|
||||||
|
if "unique" in str(e.orig).lower():
|
||||||
|
log.debug(
|
||||||
|
"race condition on pubsub node creation in cache, trying "
|
||||||
|
"again"
|
||||||
|
)
|
||||||
|
else:
|
||||||
|
raise e
|
||||||
|
break
|
||||||
|
else:
|
||||||
|
raise exceptions.InternalError(
|
||||||
|
"Too many IntegrityError with UNIQUE constraint, something is going wrong"
|
||||||
)
|
)
|
||||||
|
|
||||||
if analyse.get("to_sync"):
|
if analyse.get("to_sync"):
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue