From b5303be035ee224d13e4250145eb5ef76ddee151 Mon Sep 17 00:00:00 2001
From: Goffi <goffi@goffi.org>
Date: Mon, 27 Jan 2020 19:53:31 +0100
Subject: [PATCH] plugin XEP-0184: show a warning and the message XML on
 missing `id`

---
 sat/plugins/plugin_xep_0184.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sat/plugins/plugin_xep_0184.py b/sat/plugins/plugin_xep_0184.py
index beae41bb..d575b16e 100644
--- a/sat/plugins/plugin_xep_0184.py
+++ b/sat/plugins/plugin_xep_0184.py
@@ -152,7 +152,11 @@ class XEP_0184(object):
 
         if self._isActif(client.profile) and client.roster.isPresenceAuthorised(from_jid):
             received_elt_ret = domish.Element((NS_MESSAGE_DELIVERY_RECEIPTS, "received"))
-            received_elt_ret["id"] = msg_elt["id"]
+            try:
+                received_elt_ret["id"] = msg_elt["id"]
+            except KeyError:
+                log.warning(f"missing id for message element: {msg_elt.toXml}")
+                return
 
             msg_result_elt = xmlstream.toResponse(msg_elt, "result")
             msg_result_elt.addChild(received_elt_ret)