From 93e4021b86d7b0c2fd4342c1fe9c0d4798ff24e6 Mon Sep 17 00:00:00 2001 From: Goffi Date: Fri, 4 Jun 2021 17:18:44 +0200 Subject: [PATCH] plugin XEP-0277: don't wrap `DataError` in `failure.Failure` in `parseCommentUrl` as it is not catched correctly: `failure.Failure` is subclass of `BaseException` but not of `Exception`, as a result `except Exception` doesn't catch it correctly. This is fixed by not wrapping `DataError` in `failure.Failure` anymore. --- sat/plugins/plugin_xep_0277.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sat/plugins/plugin_xep_0277.py b/sat/plugins/plugin_xep_0277.py index cd922247..3017c136 100644 --- a/sat/plugins/plugin_xep_0277.py +++ b/sat/plugins/plugin_xep_0277.py @@ -1005,7 +1005,7 @@ class XEP_0277(object): node = parsed_queries.get("node", [""])[0] if not node: - raise failure.Failure(exceptions.DataError("Invalid comments link")) + raise exceptions.DataError("Invalid comments link") return (service, node)