core, frontends: refactoring to base Libervia on QuickFrontend (big mixed commit):

/!\ not finished, everything is still instable !
    - bridge: DBus bridge has been modified to allow blocking call to be called in the same way as asynchronous calls
    - bridge: calls with a callback and no errback are now possible, default errback log the error
    - constants: removed hack to manage presence without OrderedDict, as an OrderedDict like class has been implemented in Libervia
    - core: getLastResource has been removed and replaced by getMainResource (there is a global better management of resources)
    - various style improvments: use of constants when possible, fixed variable overlaps, import of module instead of direct class import
    - frontends: printInfo and printMessage methods in (Quick)Chat are more generic (use of extra instead of timestamp)
    - frontends: bridge creation and option parsing (command line arguments) are now specified by the frontend in QuickApp __init__
    - frontends: ProfileManager manage a more complete plug sequence (some stuff formerly manage in contact_list have moved to ProfileManager)
    - quick_frontend (quick_widgets): QuickWidgetsManager is now iterable (all widgets are then returned), or can return an iterator on a specific class (return all widgets of this class) with getWidgets
    - frontends: tools.jid can now be used in Pyjamas, with some care
    - frontends (XMLUI): profile is now managed
    - core (memory): big improvment on entities cache management (and specially resource management)
    - core (params/exceptions): added PermissionError
    - various fixes and improvments, check diff for more details

src/bridge/DBus.py

@@ -285,8 +285,8 @@ class DbusObject(dbus.service.Object):
     @dbus.service.method(const_INT_PREFIX+const_CORE_SUFFIX,
                          in_signature='ss', out_signature='s',
                          async_callbacks=None)
-    def getLastResource(self, contact_jid, profile_key="@DEFAULT@"):
-        return self._callback("getLastResource", unicode(contact_jid), unicode(profile_key))
+    def getMainResource(self, contact_jid, profile_key="@DEFAULT@"):
+        return self._callback("getMainResource", unicode(contact_jid), unicode(profile_key))
 
     @dbus.service.method(const_INT_PREFIX+const_CORE_SUFFIX,
                          in_signature='ss', out_signature='s',

src/bridge/bridge_constructor/bridge_constructor.py

@@ -446,17 +446,35 @@ class DbusConstructor(Constructor):
                 'args': self.getArguments(function['sig_in'], name=arg_doc, default=default)}
 
             if function["type"] == "method":
+                # XXX: we can manage blocking call in the same way as async one: if callback is None the call will be blocking
                 completion['debug'] = "" if not self.options.debug else 'log.debug ("%s")\n%s' % (section, 8 * ' ')
                 completion['args_result'] = self.getArguments(function['sig_in'], name=arg_doc)
-                completion['async_args'] = 'callback=None, errback=None' if async else ''
-                completion['async_comma'] = ', ' if async and function['sig_in'] else ''
-                completion['error_handler'] = ("error_handler = None if callback is None else lambda err:errback(dbus_to_bridge_exception(err))\n" + 8*" ") if async else ''
-                completion['async_args_result'] = 'timeout=const_TIMEOUT, reply_handler=callback, error_handler=error_handler' if async else ''
+                completion['async_args'] = 'callback=None, errback=None'
+                completion['async_comma'] = ', ' if function['sig_in'] else ''
+                completion['error_handler'] = """if callback is None:
+            error_handler = None
+        else:
+            if errback is None:
+                errback = log.error
+            error_handler = lambda err:errback(dbus_to_bridge_exception(err))
+        """
+                if async:
+                    completion['blocking_call'] = ''
+                    completion['async_args_result'] = 'timeout=const_TIMEOUT, reply_handler=callback, error_handler=error_handler'
+                else:
+                    # XXX: To have a blocking call, we must have not reply_handler, so we test if callback exists, and add reply_handler only in this case
+                    completion['blocking_call'] = """kwargs={}
+        if callback is not None:
+            kwargs['timeout'] = const_TIMEOUT
+            kwargs['reply_handler'] = callback
+            kwargs['error_handler'] = error_handler
+        """
+                    completion['async_args_result'] = '**kwargs'
                 result = "self.db_%(category)s_iface.%(name)s(%(args_result)s%(async_comma)s%(async_args_result)s)" % completion
                 completion['result'] = ("unicode(%s)" if self.options.unicode and function['sig_out'] == 's' else "%s") % result
                 methods_part.append("""\
     def %(name)s(self, %(args)s%(async_comma)s%(async_args)s):
-        %(error_handler)s%(debug)sreturn %(result)s
+        %(error_handler)s%(blocking_call)s%(debug)sreturn %(result)s
 """ % completion)
 
         #at this point, methods_part should be filled,

src/bridge/bridge_constructor/bridge_template.ini

@@ -279,7 +279,7 @@ doc_param_0=group: name of the group to check
 doc_param_1=%(doc_profile_key)s
 doc_return=array of jids
 
-[getLastResource]
+[getMainResource]
 type=method
 category=core
 sig_in=ss
@@ -288,7 +288,7 @@ param_1_default="@DEFAULT@"
 doc=Return the last resource connected for a contact
 doc_param_0=contact_jid: jid of the contact
 doc_param_1=%(doc_profile_key)s
-doc_return=the last resource connected of the contact, or ""
+doc_return=the resource connected of the contact with highest priority, or ""
 
 [getPresenceStatuses]
 type=method

src/bridge/bridge_constructor/dbus_frontend_template.py

@@ -102,10 +102,10 @@ class DBusBridgeFrontend(BridgeFrontend):
                 async = False
 
                 if kwargs:
-                    if 'callback' in kwargs and 'errback' in kwargs:
+                    if 'callback' in kwargs:
                         async = True
                         _callback = kwargs.pop('callback')
-                        _errback = kwargs.pop('errback')
+                        _errback = kwargs.pop('errback', lambda failure: log.error(unicode(failure)))
                 elif len(args) >= 2 and callable(args[-1]) and callable(args[-2]):
                     async = True
                     args = list(args)
@@ -122,4 +122,5 @@ class DBusBridgeFrontend(BridgeFrontend):
                 return method(*args, **kwargs)
 
             return getPluginMethod
+
 ##METHODS_PART##