From 89c23c8a4cd923f4a10328f5c5afb6dbdfe0df14 Mon Sep 17 00:00:00 2001 From: Goffi Date: Mon, 4 May 2026 16:47:42 +0200 Subject: [PATCH] plugin XEP-0084: Fix double feature advertising: `NS_AVATAR_METADATA` is already advertised by `add_pep_event`, adding it to `getDiscoInfo` too was resulting in double advertising, making the disco infos invalid for caching (resulting in other devices repeatedly requesting disco#info). --- libervia/backend/plugins/plugin_xep_0084.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libervia/backend/plugins/plugin_xep_0084.py b/libervia/backend/plugins/plugin_xep_0084.py index 0e8169bc..0cef86c4 100644 --- a/libervia/backend/plugins/plugin_xep_0084.py +++ b/libervia/backend/plugins/plugin_xep_0084.py @@ -236,8 +236,9 @@ class XEP_0084: class XEP_0084_Handler(XMPPHandler): def getDiscoInfo(self, requestor, service, nodeIdentifier=""): + # NS_AVATAR_METADATA is already advertised by ``add_pep_event``. + # Only NS_AVATAR_DATA needs to be advertised here. return [ - disco.DiscoFeature(NS_AVATAR_METADATA), disco.DiscoFeature(NS_AVATAR_DATA), ]