From 71cfdccb5b15f46502b99f443f52073c606b6458 Mon Sep 17 00:00:00 2001 From: Goffi Date: Wed, 16 Aug 2023 18:28:32 +0200 Subject: [PATCH] plugin XEP-0166: reject session creation is session ID is empty --- libervia/backend/plugins/plugin_xep_0166/__init__.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libervia/backend/plugins/plugin_xep_0166/__init__.py b/libervia/backend/plugins/plugin_xep_0166/__init__.py index 9de406fa..16e08ad3 100644 --- a/libervia/backend/plugins/plugin_xep_0166/__init__.py +++ b/libervia/backend/plugins/plugin_xep_0166/__init__.py @@ -184,6 +184,10 @@ class XEP_0166: @raise ValueError: If the provided role is neither initiator nor responder. """ # TODO: session cleaning after timeout ? + + if not sid: + raise exceptions.DataError("Empty session ID is not allowed") + if role not in [XEP_0166.ROLE_INITIATOR, XEP_0166.ROLE_RESPONDER]: raise ValueError(f"Invalid role {role}. Expected initiator or responder.")