massive refactoring to switch from camelCase to snake_case:

historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a

View file

@ -33,7 +33,7 @@ class Notify(object):
from Xlib import display as X_display
self.display = X_display.Display()
self.X11_id = self.getFocus()
self.X11_id = self.get_focus()
except:
pass
@ -51,24 +51,24 @@ class Notify(object):
except:
self.freedesktop_int = None
def getFocus(self):
def get_focus(self):
if not self.display:
return 0
return self.display.get_input_focus().focus.id
def hasFocus(self):
return (self.getFocus() == self.X11_id) if self.display else True
def has_focus(self):
return (self.get_focus() == self.X11_id) if self.display else True
def useX11(self):
def use_x11(self):
return bool(self.display)
def sendNotification(self, summ_mess, body_mess=""):
def send_notification(self, summ_mess, body_mess=""):
"""Send notification to the user if possible"""
# TODO: check options before sending notifications
if self.freedesktop_int:
self.sendFDNotification(summ_mess, body_mess)
self.send_fd_notification(summ_mess, body_mess)
def sendFDNotification(self, summ_mess, body_mess=""):
def send_fd_notification(self, summ_mess, body_mess=""):
"""Send notification with the FreeDesktop D-Bus API"""
if self.freedesktop_int:
app_name = "Primitivus"