massive refactoring to switch from camelCase to snake_case:

historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a

View file

@ -128,7 +128,7 @@ class Create(base.CommandBase):
)
try:
invitation_data = await self.host.bridge.invitationCreate(
invitation_data = await self.host.bridge.invitation_create(
email,
emails_extra,
self.args.jid,
@ -178,7 +178,7 @@ class Get(base.CommandBase):
async def start(self):
try:
invitation_data = await self.host.bridge.invitationGet(
invitation_data = await self.host.bridge.invitation_get(
self.args.id,
)
except Exception as e:
@ -190,7 +190,7 @@ class Get(base.CommandBase):
else:
profile = invitation_data["guest_profile"]
try:
await self.host.bridge.profileStartSession(
await self.host.bridge.profile_start_session(
invitation_data["password"],
profile,
)
@ -199,7 +199,7 @@ class Get(base.CommandBase):
self.host.quit(C.EXIT_BRIDGE_ERRBACK)
try:
jid_ = await self.host.bridge.asyncGetParamA(
jid_ = await self.host.bridge.param_get_a_async(
"JabberID",
"Connection",
profile_key=profile,
@ -226,7 +226,7 @@ class Delete(base.CommandBase):
async def start(self):
try:
await self.host.bridge.invitationDelete(
await self.host.bridge.invitation_delete(
self.args.id,
)
except Exception as e:
@ -302,7 +302,7 @@ class Modify(base.CommandBase):
)
extra[arg_name] = value
try:
await self.host.bridge.invitationModify(
await self.host.bridge.invitation_modify(
self.args.id,
extra,
self.args.replace,
@ -348,7 +348,7 @@ class List(base.CommandBase):
async def start(self):
try:
data = await self.host.bridge.invitationList(
data = await self.host.bridge.invitation_list(
self.args.profile,
)
except Exception as e: