massive refactoring to switch from camelCase to snake_case:

historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a

View file

@ -47,9 +47,9 @@ class Get(base.CommandBase):
)
self.parser.add_argument("jid", nargs='?', default='', help=_("entity"))
async def showImage(self, path):
sat_conf = config.parseMainConf()
cmd = config.getConfig(sat_conf, C.CONFIG_SECTION, "image_cmd")
async def show_image(self, path):
sat_conf = config.parse_main_conf()
cmd = config.config_get(sat_conf, C.CONFIG_SECTION, "image_cmd")
cmds = [cmd] + DISPLAY_CMD if cmd else DISPLAY_CMD
for cmd in cmds:
try:
@ -72,7 +72,7 @@ class Get(base.CommandBase):
async def start(self):
try:
avatar_data_raw = await self.host.bridge.avatarGet(
avatar_data_raw = await self.host.bridge.avatar_get(
self.args.jid,
not self.args.no_cache,
self.profile,
@ -91,7 +91,7 @@ class Get(base.CommandBase):
self.disp(avatar_path)
if self.args.show:
await self.showImage(avatar_path)
await self.show_image(avatar_path)
self.host.quit()
@ -117,7 +117,7 @@ class Set(base.CommandBase):
self.host.quit(C.EXIT_BAD_ARG)
path = os.path.abspath(path)
try:
await self.host.bridge.avatarSet(path, self.args.jid, self.profile)
await self.host.bridge.avatar_set(path, self.args.jid, self.profile)
except Exception as e:
self.disp(f"can't set avatar: {e}", error=True)
self.host.quit(C.EXIT_BRIDGE_ERRBACK)