massive refactoring to switch from camelCase to snake_case:

historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a

View file

@ -27,7 +27,7 @@ import urllib.request, urllib.parse, urllib.error
# FIXME: basic implementation, need to follow RFC 5122
def parseXMPPUri(uri):
def parse_xmpp_uri(uri):
"""Parse an XMPP uri and return a dict with various information
@param uri(unicode): uri to parse
@ -87,7 +87,7 @@ def parseXMPPUri(uri):
return data
def addPairs(uri, pairs):
def add_pairs(uri, pairs):
for k, v in pairs.items():
uri.append(
";"
@ -97,7 +97,7 @@ def addPairs(uri, pairs):
)
def buildXMPPUri(type_: Optional[str] = None, **kwargs: str) -> str:
def build_xmpp_uri(type_: Optional[str] = None, **kwargs: str) -> str:
uri = ["xmpp:"]
subtype = kwargs.pop("subtype", None)
path = kwargs.pop("path")
@ -114,7 +114,7 @@ def buildXMPPUri(type_: Optional[str] = None, **kwargs: str) -> str:
kwargs["node"] = "urn:xmpp:microblog:0"
if kwargs:
uri.append("?")
addPairs(uri, kwargs)
add_pairs(uri, kwargs)
else:
raise NotImplementedError("{type_} URI are not handled yet".format(type_=type_))