erebion/libervia-backend
Watch
1
0
Fork
You've already forked libervia-backend
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

massive refactoring to switch from camelCase to snake_case:

Browse source 
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a
1 changed files with 9945 additions and 9945 deletions
Download patch file Download diff file Expand all files Collapse all files

12
sat/tools/async_trigger.py
View file

@ -25,10 +25,10 @@ from . import utils
from twisted.internet import defer
class TriggerManager(sync_trigger.TriggerManager):
"""This is a TriggerManager with an new asyncPoint method"""
"""This is a TriggerManager with an new async_point method"""
@defer.inlineCallbacks
def asyncPoint(self, point_name, *args, **kwargs):
def async_point(self, point_name, *args, **kwargs):
"""This put a trigger point with potentially async Deferred
All the triggers for that point will be run
@ -47,25 +47,25 @@ class TriggerManager(sync_trigger.TriggerManager):
for priority, trigger in self.__triggers[point_name]:
try:
cont = yield utils.asDeferred(trigger, *args, **kwargs)
cont = yield utils.as_deferred(trigger, *args, **kwargs)
if can_cancel and not cont:
defer.returnValue(False)
except sync_trigger.SkipOtherTriggers:
break
defer.returnValue(True)
async def asyncReturnPoint(
async def async_return_point(
self,
point_name: str,
*args, **kwargs
) -> Tuple[bool, Any]:
"""Async version of returnPoint"""
"""Async version of return_point"""
if point_name not in self.__triggers:
return True, None
for priority, trigger in self.__triggers[point_name]:
try:
cont, ret_value = await utils.asDeferred(trigger, *args, **kwargs)
cont, ret_value = await utils.as_deferred(trigger, *args, **kwargs)
if not cont:
return False, ret_value
except sync_trigger.SkipOtherTriggers: