erebion/libervia-backend
Watch
1
0
Fork
You've already forked libervia-backend
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

massive refactoring to switch from camelCase to snake_case:

Browse source 
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a
1 changed files with 9945 additions and 9945 deletions
Download patch file Download diff file Expand all files Collapse all files

14
sat/test/test_plugin_misc_text_syntaxes.py
View file

@ -78,15 +78,15 @@ class SanitisationTest(helpers.SatTestCase):
</img></body>
</div>"""
d = self.text_syntaxes.cleanXHTML(self.EVIL_HTML1)
d.addCallback(self.assertEqualXML, expected, ignore_blank=True)
d = self.text_syntaxes.clean_xhtml(self.EVIL_HTML1)
d.addCallback(self.assert_equal_xml, expected, ignore_blank=True)
return d
def test_styles_sanitise(self):
expected = """<p style="color: blue">test <strong>retest</strong><br/><span style="color: #cf2828; font-size: 3px; color: red; color: red !important; font-size: 100px !important; font-size: 100%; font-size: 100px; font-size: 100; font-size: 100 %; color: rgba(0, 0, 0, 0.1); color: rgb(35,79,255); background-color: no-repeat"> toto </span></p>"""
d = self.text_syntaxes.cleanXHTML(self.EVIL_HTML2)
d.addCallback(self.assertEqualXML, expected)
d = self.text_syntaxes.clean_xhtml(self.EVIL_HTML2)
d.addCallback(self.assert_equal_xml, expected)
return d
def test_html2text(self):
@ -105,11 +105,11 @@ class SanitisationTest(helpers.SatTestCase):
d.addCallback(self.assertEqual, expected)
return d
def test_removeXHTMLMarkups(self):
def test_remove_xhtml_markups(self):
expected = """ a link another link a paragraph secret EVIL! of EVIL! Password: annoying EVIL! spam spam SPAM! """
result = self.text_syntaxes._removeMarkups(self.EVIL_HTML1)
result = self.text_syntaxes._remove_markups(self.EVIL_HTML1)
self.assertEqual(re.sub(r"\s+", " ", result).rstrip(), expected.rstrip())
expected = """test retest toto"""
result = self.text_syntaxes._removeMarkups(self.EVIL_HTML2)
result = self.text_syntaxes._remove_markups(self.EVIL_HTML2)
self.assertEqual(re.sub(r"\s+", " ", result).rstrip(), expected.rstrip())