massive refactoring to switch from camelCase to snake_case:

historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.

However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.

To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.

This is a massive change, and may result in some bugs.
This commit is contained in:
Goffi 2023-04-08 13:54:42 +02:00
commit 6a6f15707a

View file

@ -28,7 +28,7 @@ import string
from twisted.internet import defer
def getRandomUnicode(len):
def get_random_unicode(len):
"""Return a random unicode string"""
return "".join(random.choice(string.letters + "éáúóâêûôßüöä") for i in range(len))
@ -47,9 +47,9 @@ class CryptoTest(helpers.SatTestCase):
d_list.append(d)
for key_len in (0, 2, 8, 10, 16, 24, 30, 32, 40):
key = getRandomUnicode(key_len)
key = get_random_unicode(key_len)
for message_len in (0, 2, 16, 24, 32, 100):
message = getRandomUnicode(message_len)
message = get_random_unicode(message_len)
test(key, message)
return defer.DeferredList(d_list)
@ -62,7 +62,7 @@ class CryptoTest(helpers.SatTestCase):
d1 = PasswordHasher.verify(password, hashed)
d1.addCallback(lambda result: self.assertTrue(result))
d_list.append(d1)
attempt = getRandomUnicode(10)
attempt = get_random_unicode(10)
d2 = PasswordHasher.verify(attempt, hashed)
d2.addCallback(lambda result: self.assertFalse(result))
d_list.append(d2)